Repository navigation
WIP: Bundled Themes: Update Ipsum for 7.2 RC 1 - #15948
Draft
MaggieCabrera wants to merge 13 commits into
Draft
MaggieCabrera wants to merge 13 commits into
MaggieCabrera wants to merge 13 commits into
Conversation
These follow up on the review of the 7.2 Beta 5 sync. The front end picks `style.min.css` with a plain `SCRIPT_DEBUG` check, as Twenty Twenty-Five does, instead of comparing file times, and `style.css` gets Twenty Twenty-Five's note against editing it in the Theme File Editor. The template descriptions now say "the theme header" and "the theme footer", and the `ipsum_get_design_guide_presets()` docblock says it returns an empty list when the presets aren't an array. Synced from WordPress/ipsum#216. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The theme's paragraph line height targeted the `p` directly, so it beat a custom line height set on a Pullquote, Quote or Group. The `1.6` line height now sits on the root instead, like in Twenty Twenty-Four and Twenty Twenty-Five, so a custom line height reaches the paragraphs inside. Lists, tables, code and citations go from `1.5` to `1.6`. Synced from WordPress/ipsum#203. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A comment or comment author name with a long string and no spaces made the whole page scroll sideways. Comment content and author names now use `overflow-wrap: anywhere`, so they wrap inside the comment box. Synced from WordPress/ipsum#200. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The `ipsum/get-design-guide` ability now returns only the basic design sections by default, and the larger lists, such as patterns and templates, are available through `fields`. Its schema gets clearer translated titles and descriptions, and marks the nested fields that are always there. The tests live in core, since Ipsum's repository has no PHPUnit setup. They cover the ability's registration and schema, the default and requested sections, invalid input, permissions, the REST endpoint, and how the guide follows the saved global styles and customized templates. Synced from WordPress/ipsum#193. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Archive Minimal, Archive Simple and All Archives Sidebar patterns hard-coded the `M j` date format, so the short date couldn't follow the site's language. The format is now a translatable string. Synced from WordPress/ipsum#224. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Details block's triangle markers get empty text alternatives, so screen readers don't read them aloud. They stay visible, and the block still announces whether it's expanded. Synced from WordPress/ipsum#230. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Bio, Blog Home, Coming Soon and Text Statement Wide patterns set a left text alignment on seven headings and paragraphs, so they stayed on the left on RTL sites. Without it, they follow the text direction. Synced from WordPress/ipsum#226. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The open overlay's submenus and the vertical submenus were indented on the left, so on RTL sites they lined up with their parent item. The indent now uses `padding-inline-start`, so it follows the text direction. Synced from WordPress/ipsum#225. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The navigation in the overlay patterns was named "Expanded". It's now named "Primary", which says what it's for and matches the header navigation. Synced from WordPress/ipsum#228. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…view. `contributing.txt` says Ipsum is developed on GitHub until 1.0, and that contributions go through Trac after that. It also drops the note about `style.css` being used when it's newer than `style.min.css`, since the theme now checks only `SCRIPT_DEBUG`. A test message in the design guide tests says "do not match" instead of "to not match". Follow-up to [65366]. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`AGENTS.md` now covers the theme itself, so it ships with the theme, like `DESIGN.md`, and helps agents that edit Ipsum or build on it anywhere. What only applies to the GitHub repository stays there, in `CONTRIBUTING.md`, and `DESIGN.md` links to `AGENTS.md` for working on the theme's files. Synced from WordPress/ipsum#214. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The space between the comment form's "Save my name…" checkbox and its label was always on the right, so it shrank on RTL sites. The checkbox now uses logical margins, which follow the text direction. LTR sites look the same as before. Synced from WordPress/ipsum#231. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
MaggieCabrera
force-pushed
the
sync/ipsum
branch
from
November 12, 2026 15:38
04fb6bc to
2a1a953
Compare
…y tests. Aligns the array arrows in a data provider, which the PHP coding standards check flagged. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: This collects the Ipsum PRs merged since the last sync. It'll be committed late on Monday, November 16, or early on Tuesday, November 17, so it includes everything merged until then.
This merges the latest improvements to Ipsum from https://github.com/WordPress/ipsum into
trunkfor 7.2 RC 1. Each commit brings over one merged Ipsum PR and links it, so they can be committed together or one at a time.Only theme files come over. Repository tooling and development docs stay on GitHub, like in the import.
The commit for WordPress/ipsum#193 also adds its tests in
tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php. They live in core because Ipsum's repository has no PHPUnit setup.The last commit fixes core-only files from the 7.2 Beta 5 review:
contributing.txtsays contributions go through Trac after 1.0 and drops the oldstyle.min.cssnote, and a test message inipsumDesignGuide.phpsays "do not match".Some of these PRs add or change translatable strings, so this needs to land before the hard string freeze at RC 1.
Ipsum PRs included so far:
A full list of changes can be found on GitHub: WordPress/ipsum@bc2e5af...cc861f7
Trac ticket: https://core.trac.wordpress.org/ticket/66678
Testing Instructions
src/wp-content/themes/ipsummatches the theme files on Ipsum'strunk.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Watching the Ipsum repository for merges and bringing each one over as a commit. Every change was reviewed in its Ipsum PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code