Repository navigation
Conversation
…der. Place the media modal close button and the Edit Attachment header buttons after the frame title, so that the DOM order matches the visual order for screen readers and other assistive technologies. See #66270.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In the media modals, the header buttons come before the heading in the DOM but are displayed after it. This creates a mismatch between DOM order and visual order for screen reader users navigating content (arrow keys, "read all").
.media-frame-titlenow comes before.edit-media-header(Previous, Next, Close) intmpl-edit-attachment-frame..media-frame-title. Modals without a frame title keep the current markup, so customwp.media.view.Modalusages are unaffected.All of these buttons are absolutely positioned, so the visual layout is unchanged.
Trac ticket: https://core.trac.wordpress.org/ticket/66270
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Code analysis, implementation and PR description; reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code