Skip to content

Media: Match the DOM order of the media modal header to its visual order - #15949

Open
ozgursar wants to merge 1 commit into
WordPress:trunkfrom
ozgursar:fix/66270-media-modal-dom-order
Open

ozgursar wants to merge 1 commit into
WordPress:trunkfrom
ozgursar:fix/66270-media-modal-dom-order

Conversation

@ozgursar

Copy link
Copy Markdown

In the media modals, the header buttons come before the heading in the DOM but are displayed after it. This creates a mismatch between DOM order and visual order for screen reader users navigating content (arrow keys, "read all").

  • Edit Attachment modal: .media-frame-title now comes before .edit-media-header (Previous, Next, Close) in tmpl-edit-attachment-frame.
  • Media modal: when the modal opens, its close button is moved directly after .media-frame-title. Modals without a frame title keep the current markup, so custom wp.media.view.Modal usages are unaffected.

All of these buttons are absolutely positioned, so the visual layout is unchanged.

Trac ticket: https://core.trac.wordpress.org/ticket/66270

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Code analysis, implementation and PR description; reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

…der.

Place the media modal close button and the Edit Attachment header buttons after the frame title, so that the DOM order matches the visual order for screen readers and other assistive technologies.

See #66270.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ozgursar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant