Skip to content

Site Health: Demonstrate the version check test never reporting on multisite #15953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
desrosj wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Site Health: Demonstrate the version check test never reporting on multisite #15953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions tests/phpunit/tests/admin/wpSiteHealthAutoUpdates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,82 @@ public function test_vcs_abspath_should_report_git_file() {
$this->assertStringContainsString( '<code>' . ABSPATH . '</code>', $result['description'] );
$this->assertStringContainsString( '<code>.git</code>', $result['description'] );
}

/**
* Tests that the test reports a plugin removing wp_version_check() from
* its hook on a single site install.
*
* This is the baseline for
* test_wp_version_check_attached_should_report_removed_check_on_main_site().
*
* @group ms-excluded
*
* @covers WP_Site_Health_Auto_Updates::test_wp_version_check_attached
*/
public function test_wp_version_check_attached_should_report_removed_check() {
remove_action( 'wp_version_check', 'wp_version_check' );

$health_check = new WP_Site_Health_Auto_Updates();
$result = $health_check->test_wp_version_check_attached();

$this->assertIsArray( $result, 'The test should report the removed version check.' );
$this->assertSame( 'fail', $result['severity'] );
}

/**
* Tests that the test reports a plugin removing wp_version_check() from
* its hook on the main site of a network.
*
* wp-includes/update.php only hooks wp_version_check() on the main site,
* so the test is limited to the main site on multisite (see #52135). It
* also requires the network admin, where Site Health has no screen, and
* the background updates test runs through the REST API, where
* is_network_admin() is false. The test never reports a problem on
* multisite as a result.
*
* @ticket 52135
* @group multisite
* @group ms-required
*
* @covers WP_Site_Health_Auto_Updates::test_wp_version_check_attached
*/
public function test_wp_version_check_attached_should_report_removed_check_on_main_site() {
$this->assertTrue( is_main_site(), 'The test should run on the main site.' );
$this->assertFalse( is_network_admin(), 'Site Health does not run in the network admin.' );

remove_action( 'wp_version_check', 'wp_version_check' );

$health_check = new WP_Site_Health_Auto_Updates();
$result = $health_check->test_wp_version_check_attached();

$this->assertIsArray( $result, 'The test should report the removed version check on the main site.' );
$this->assertSame( 'fail', $result['severity'] );
}

/**
* Tests that the test does not report a missing wp_version_check() hook
* on a site other than the main site of a network.
*
* wp-includes/update.php only hooks wp_version_check() on the main site,
* so the hook is always missing on other sites.
*
* @ticket 52135
* @group multisite
* @group ms-required
*
* @covers WP_Site_Health_Auto_Updates::test_wp_version_check_attached
*/
public function test_wp_version_check_attached_should_not_report_on_other_sites() {
$site_id = self::factory()->blog->create();
switch_to_blog( $site_id );

remove_action( 'wp_version_check', 'wp_version_check' );

$health_check = new WP_Site_Health_Auto_Updates();
$result = $health_check->test_wp_version_check_attached();

restore_current_blog();

$this->assertNull( $result );
}
}
Loading