Repository navigation
Posts, Post Types: Bail early in _reset_front_page_settings_for_post() when the post no longer exists - #15955
Conversation
…) when the post no longer exists.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…ront_page_settings_for_post().
…post no longer exists.
When another request deletes the same post while
wp_delete_post()is running,_reset_front_page_settings_for_post()gets null fromget_post()and triggersAttempt to read property "post_type" on null. This returns early when the post no longer exists.On multisite,
_update_blog_date_on_post_delete()has the same issue ondelete_postand gets the same early return.The test deletes the post from a
before_delete_postcallback at priority 1. It fails on trunk with the warning and passes with the fix.Trac ticket: https://core.trac.wordpress.org/ticket/66684
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigating the bug, writing the patch and test, and drafting this description; reviewed and tested by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.