Repository navigation
Sitemaps: Support provider names containing dashes, digits, and underscores. - #15958
TremiDkhar wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Sitemap providers registered with a name containing a dash, such as
wp_register_sitemap_provider( 'custom-plugin', $provider ), are listed in the sitemap index, but their URL shows the home page instead of the sitemap.The rewrite rules only match
[a-z]for the provider name, sowp-sitemap-custom-plugin-1.xmlis parsed as providercustomwith object subtypeplugin. Names with digits or underscores don't match at all.This PR:
[a-z\d_-].WP_Sitemaps::render_sitemaps(), when the parsed provider and subtype don't match a registered provider, matches the full route against the registered provider names.Core sitemaps (posts, taxonomies, users) are parsed as before.
Testing Instructions
Add this mu-plugin and flush permalinks:
Open
/wp-sitemap.xmland click thewp-sitemap-custom-plugin-1.xmllink.Before the patch: the theme's 404 page is shown. After the patch: the sitemap lists
/custom-url/.Check that
/wp-sitemap-posts-post-1.xmlstill works.Unit tests can be added once the approach is agreed on.
Trac ticket: https://core.trac.wordpress.org/ticket/51280
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigating the bug, drafting the fix and this description; the final change was reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.