Repository navigation
Conversation
… backslash Markdown tables need a pipe in a cell escaped as `\|`, and GitHub Flavored Markdown removes that backslash anywhere in the cell, including inside code spans. Jetpack's parser only does so outside code spans, so imported handbook pages showed values like `string\|null` where the source means `string|null`. Remove the escaping backslash inside table cells after the transform. Fixes #5123. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
@propsbot add noisysocks |
Fixes https://meta.trac.wordpress.org/ticket/5123
A pipe inside a Markdown table cell has to be escaped as
\|. GitHub Flavored Markdown removes that backslash anywhere in the cell, including inside code spans, so GitHub showsstring|null. Jetpack’s parser only drops it outside code spans, so imported handbook pages show the backslash. Thepackages-envpage currently has five such cells, for example the type ofcore,phpVersionandmariadbVersionreadsstring\|null.After the Markdown transform, the importer now replaces
\|with|inside<td>and<th>elements. Code outside tables and fenced code blocks keep their backslashes, as in GFM.Testing
string\|nullin the Type column, and.<path>\|~<path>and/<path>\|<letter>:\<path>in the source type table.string|null,.<path>|~<path>and/<path>|<letter>:\<path>(the backslash before<path>stays, as on GitHub).\|outside a table, and a fenced code block containing\|: both keep the backslash.Running the Jetpack parser on the current
packages/env/README.mdbefore and after this change differs in exactly those five cells.🤖 Generated with Claude Code