You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rosetta: Translation Teams: Don't read post content when no post is queried - #1258
Follow-up to #1257. On singular requests that have no queried post, such as a post’s comment feed (/polyglots/2026/11/06/<slug>/feed/), get_displayed_locale() read post_content off null. That logged “Attempt to read property "post_content" on null” from the wporg_canonical_url filter.
This looks up the requested locale first, so requests without a valid ?locale= return before touching the post. It then reads the content only when the queried object is a WP_Post.
Testing
Open a Polyglots post’s comment feed, for example https://make.wordpress.org/polyglots/2026/11/06/pte-request-for-depicter-chinese-singapore/feed/, and check that no warning is logged.
Open https://make.wordpress.org/polyglots/teams/?locale=id_ID and check that the title still names Indonesian and the canonical still carries ?locale=id_id.
Open https://make.wordpress.org/polyglots/teams/ and check that the title and canonical are the overview page’s.
Locale display now handles invalid locale requests and pages that aren’t eligible for locale information more safely. This prevents locale details from appearing in unsupported page contexts and avoids errors when page content is unavailable or doesn’t contain locale information.
…ueried
On singular requests without a queried post, such as a post's comment
feed, get_displayed_locale() read post_content off null and logged a
warning from the wporg_canonical_url filter. Look up the requested locale
first so most requests return early, and only read the content of a
queried WP_Post.
See #4683.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
get_displayed_locale() now resolves the requested locale before checking page context. It returns null when the request or queried object does not meet the added checks.
The function returns null if no locale was requested or the page is not singular. It checks that the queried object is a WP_Post containing the [wp-locales] shortcode before returning the locale.
This change stops a PHP warning on comment feeds of singular requests that have no queried post. Title and canonical behavior for valid locale requests is reported as preserved. No actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: get_displayed_locale() no longer reads post_content when no post is queried. The raw summary confirms the locale is resolved first and post_content is read only from a…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: get_displayed_locale() no longer reads post_content when no post is queried. The raw summary confirms the locale is resolved first and post_content is read only from a WP_Post. The title's wording matches the described change and the PR objectives, so it is related to the changeset.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://meta.trac.wordpress.org/ticket/4683
Follow-up to #1257. On singular requests that have no queried post, such as a post’s comment feed (
/polyglots/2026/11/06/<slug>/feed/),get_displayed_locale()readpost_contentoffnull. That logged “Attempt to read property "post_content" on null” from thewporg_canonical_urlfilter.This looks up the requested locale first, so requests without a valid
?locale=return before touching the post. It then reads the content only when the queried object is aWP_Post.Testing
https://make.wordpress.org/polyglots/2026/11/06/pte-request-for-depicter-chinese-singapore/feed/, and check that no warning is logged.https://make.wordpress.org/polyglots/teams/?locale=id_IDand check that the title still names Indonesian and the canonical still carries?locale=id_id.https://make.wordpress.org/polyglots/teams/and check that the title and canonical are the overview page’s.🤖 Generated with Claude Code
Summary by CodeRabbit