You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make: Stop showing “Page not found” to people with no posts or mentions yet - #1259
The “My Posts” and “My @Mentions” links in the Make sidebar filter go to the current user’s author archive (/author/<login>/) and mentions archive (?mentions=<login>). When someone hasn’t posted or been mentioned on that site yet, both return a 404 “Page not found”, which reads as a broken link rather than an empty list. Core only keeps an empty author archive as a 200 for site members, and most Make users aren’t members; a mentions archive has no term until the first mention, so it always 404s.
This adds a pre_handle_404 callback to wporg-breathe-2024 that keeps author and mentions archives as a 200 when the user exists, and a no-results-archive.php template part (picked up by the parent theme’s archive.php) that shows “No posts yet” / “No mentions yet” in the same style as the empty search results page, as suggested in comment:1. o2 replaces the server-rendered content when it loads and only draws an empty state for search and 404 views, so an o2_options filter gives these empty archives o2’s search view with the same message in place of “could not find any results”. Unknown users, paged requests, the To Do/Done filters (?resolved=) and other archives behave as before. Both archive types are already noindexed by wporg-seo.
Testing
Log in on a Make site where you have no posts and haven’t been mentioned, e.g. https://make.wordpress.org/core/ with a test account.
Click “My Posts” in the sidebar filter (https://make.wordpress.org/core/author/<your-login>/). Before: 404 “Page not found”. After: 200 with “No posts yet” and “ hasn’t published any posts here yet.”
Click “My @Mentions” (https://make.wordpress.org/core/?mentions=<your-login>). Before: 404. After: 200 with “No mentions yet” and “No posts here mention @ yet.”
On either view, click “To Do” or “Done” in the filter widget and check that nothing changed there.
Check that https://make.wordpress.org/core/author/no-such-user-zzz/ and ?mentions=no-such-user-zzz still return a 404, and that an author with posts still lists them.
I checked the status codes with a script that runs the main query and handle_404() in a multisite wp-env, on a site where the user isn’t a member (before: 404 for both; after: 200 for existing users, 404 for unknown users, paged requests and array query vars), and rendered the template part for both cases. The page itself needs a visual check on a Make site, since the p2-breathe parent theme and o2 aren’t in a local environment.
…ns yet
The “My Posts” and “My @Mentions” views in the sidebar filter link to the
current user's author and mentions archives. For anyone who hasn't
posted or been mentioned on a site yet, WordPress treats those empty
archives as a 404, so the view reads as broken rather than empty. Core
only spares author archives for site members, and most Make users aren't
members.
Keep those archives as a 200 when the user exists and show a “No posts
yet” or “No mentions yet” message, like the empty search results page.
Unknown users and paged requests still 404.
Fixes #3781.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The theme identifies users on author and mentions archives, handles eligible empty archives with HTTP 200 and archive-specific o2 options, and renders archive-specific no-results text. If no user resolves, the template uses the generic no-results template.
Changes: User archive handling
Layer / File(s)
Summary
User resolution and empty archive handling wordpress.org/public_html/wp-content/themes/pub/wporg-breathe-2024/functions.php
get_archive_user() identifies users for author and nonempty mentions queries. Eligible empty user archives receive HTTP 200. The o2 empty state uses an archive-specific message.
This change makes empty author and mentions archives return 200 with a clear empty-state message instead of a 404 page. No actionable merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: author and mentions archives for users with no posts or mentions stop returning "Page not found" (404). The raw summary and PR objectives both describe this change: a …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title names the main change: author and mentions archives for users with no posts or mentions stop returning "Page not found" (404). The raw summary and PR objectives both describe this change: a pre_handle_404 callback returns 200 for existing users, and a no-results-archive.php template part renders the empty states. The title is specific and matches the changeset.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
o2 empties the page content when it loads and only draws an empty state
for search and 404 views, so the “No posts yet” and “No mentions yet”
message never showed on Make sites. Pass the message to o2 as its search
empty state instead.
The To Do and Done filters narrow an author or mentions archive, so an
empty one there doesn't mean the user has no posts. Leave those as they
were.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://meta.trac.wordpress.org/ticket/3781
The “My Posts” and “My @Mentions” links in the Make sidebar filter go to the current user’s author archive (
/author/<login>/) and mentions archive (?mentions=<login>). When someone hasn’t posted or been mentioned on that site yet, both return a 404 “Page not found”, which reads as a broken link rather than an empty list. Core only keeps an empty author archive as a 200 for site members, and most Make users aren’t members; a mentions archive has no term until the first mention, so it always 404s.This adds a
pre_handle_404callback to wporg-breathe-2024 that keeps author and mentions archives as a 200 when the user exists, and ano-results-archive.phptemplate part (picked up by the parent theme’sarchive.php) that shows “No posts yet” / “No mentions yet” in the same style as the empty search results page, as suggested in comment:1. o2 replaces the server-rendered content when it loads and only draws an empty state for search and 404 views, so ano2_optionsfilter gives these empty archives o2’s search view with the same message in place of “could not find any results”. Unknown users, paged requests, the To Do/Done filters (?resolved=) and other archives behave as before. Both archive types are already noindexed by wporg-seo.Testing
https://make.wordpress.org/core/author/<your-login>/). Before: 404 “Page not found”. After: 200 with “No posts yet” and “ hasn’t published any posts here yet.”https://make.wordpress.org/core/?mentions=<your-login>). Before: 404. After: 200 with “No mentions yet” and “No posts here mention @ yet.”https://make.wordpress.org/core/author/no-such-user-zzz/and?mentions=no-such-user-zzzstill return a 404, and that an author with posts still lists them.I checked the status codes with a script that runs the main query and
handle_404()in a multisite wp-env, on a site where the user isn’t a member (before: 404 for both; after: 200 for existing users, 404 for unknown users, paged requests and array query vars), and rendered the template part for both cases. The page itself needs a visual check on a Make site, since the p2-breathe parent theme and o2 aren’t in a local environment.Props garrett-eclipse (no linked GitHub account).
🤖 Generated with Claude Code
Summary by CodeRabbit