Revert collect data - #47
Merged
Merged
Conversation
hackwa
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore vaiprofile-collect-data zip overwrite and drop extra dtrace globs
Branch:
feature/revert-collect-data→mainBase commit:
e38f2cd(Add uint16_t to SIZE_BYTES (#46))Summary
vaiprofile-collect-dataagain writes a singlevai_profile.zipat the hardware run directory root (overwriting if present) and no longer packsaie_dtrace_*.ctordtrace_dump_*.json. Downstream consumers that expect the original zip name and the prior file set will match that behavior again.This undoes the collection and zip-indexing changes from #41 (
2fcb0b9).vai_profile_datais still versioned asvai_profile_data_<n>when that directory already exists; only the zip stays a fixedvai_profile.zip.Changes
src/mldebug/scripts/vaiprofile-collect-dataaie_dtrace_*.ct/dtrace_dump_*.jsonglobs;rm -fthen recreatevai_profile.zipinstead ofvai_profile_<n>.zipaligned with data dirs (committed onbb8f309)Before (#41)
Also collected
aie_dtrace_*.ctanddtrace_dump_*.json.After (this PR)
Collected set is again:
aie_event_runtime_config*.json,aie_trace*.txt,dtrace_dump_ctx*.py,record_timer_*.json,onnxruntime_profile_*.json.Motivation
#41 added extra dtrace artifacts to the zip and numbered
vai_profile_<n>.zipso zip and data directories shared a suffix. That broke the previous contract: a singlevai_profile.zipat the run root, and only the original profile file types. This restore puts the collector back on that contract.