Skip to content

Revert collect data - #47

Merged
hackwa merged 1 commit into
Xilinx:mainfrom
rogerngatxilinx:feature/revert-collect-data
Sep 2, 2026
Merged

Revert collect data#47
hackwa merged 1 commit into
Xilinx:mainfrom
rogerngatxilinx:feature/revert-collect-data

Conversation

@rogerngatxilinx

Copy link
Copy Markdown
Contributor

Restore vaiprofile-collect-data zip overwrite and drop extra dtrace globs

Branch: feature/revert-collect-datamain
Base commit: e38f2cd (Add uint16_t to SIZE_BYTES (#46))

Summary

vaiprofile-collect-data again writes a single vai_profile.zip at the hardware run directory root (overwriting if present) and no longer packs aie_dtrace_*.ct or dtrace_dump_*.json. Downstream consumers that expect the original zip name and the prior file set will match that behavior again.

This undoes the collection and zip-indexing changes from #41 (2fcb0b9). vai_profile_data is still versioned as vai_profile_data_<n> when that directory already exists; only the zip stays a fixed vai_profile.zip.

Changes

File Change
src/mldebug/scripts/vaiprofile-collect-data Drop aie_dtrace_*.ct / dtrace_dump_*.json globs; rm -f then recreate vai_profile.zip instead of vai_profile_<n>.zip aligned with data dirs (committed on bb8f309)

Before (#41)

# Pick a single index shared by vai_profile_<n>.zip and vai_profile_data_<n>
out="${root}/vai_profile.zip"
profile_dir="${root}/vai_profile_data"
if [[ -e "$out" || -e "$profile_dir" ]]; then
  n=1
  while [[ -e "${root}/vai_profile_${n}.zip" || -e "${root}/vai_profile_data_${n}" ]]; do
    ((n++)) || true
  done
  out="${root}/vai_profile_${n}.zip"
  profile_dir="${root}/vai_profile_data_${n}"
fi
zip -j -q "$out" -- "${files[@]}"

Also collected aie_dtrace_*.ct and dtrace_dump_*.json.

After (this PR)

out="${root}/vai_profile.zip"
rm -f "$out"
zip -j -q "$out" -- "${files[@]}"

profile_dir="${root}/vai_profile_data"
if [[ -e "$profile_dir" ]]; then
  n=1
  while [[ -e "${root}/vai_profile_data_${n}" ]]; do
    ((n++)) || true
  done
  profile_dir="${root}/vai_profile_data_${n}"
fi

Collected set is again: aie_event_runtime_config*.json, aie_trace*.txt, dtrace_dump_ctx*.py, record_timer_*.json, onnxruntime_profile_*.json.

Motivation

#41 added extra dtrace artifacts to the zip and numbered vai_profile_<n>.zip so zip and data directories shared a suffix. That broke the previous contract: a single vai_profile.zip at the run root, and only the original profile file types. This restore puts the collector back on that contract.

@hackwa
hackwa merged commit 1793821 into Xilinx:main Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants