bench: add missing crash-recovery benchmark source#41
Merged
Conversation
…rash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly
…repairs the replay from the .recovery, it includes a test forcing a crash
* feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery
virtexalejandro
added a commit
that referenced
this pull request
Jul 20, 2026
* feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery * Feat/writer crash recovery (#39) (#40) * feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery
virtexalejandro
added a commit
that referenced
this pull request
Jul 20, 2026
#42) * fix(reader): chunk-load state tracking, loading-forever wedge, inspector window ping-pong; defer chunk frees off caller thread Adds GetResidentFrame (side-effect-free peek) + OnChunkLoadCancelled event; docs + changelog. * Fix/bucket names (#35) * fix: Fix buckets creation not being read from schema file, update schema validator to check buckets , update tests * fix: Harden a latent crash due to buckets initialization from buckets schema name, trying to access a bucket when the bucket list is empty * Feature/schema array map presizing (#36) * fix: Fix buckets creation not being read from schema file, update schema validator to check buckets , update tests * fix: Harden a latent crash due to buckets initialization from buckets schema name, trying to access a bucket when the bucket list is empty * feat: resize flat arryas and maps from schema max type * feat: ensure maps and flat arrays get resize using the schema max types * feat : recover map and arrays resizing (#37) * Feat/writer crash recovery (#38) * feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * Feat/writer crash recovery (#39) * feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery * bench: add missing crash-recovery benchmark source (#41) * feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery * Feat/writer crash recovery (#39) (#40) * feat: First phase of hardening and recovering vtx file in case of a crash. Implement a durable_file class that syncs and flushes to hard disk, file_sink uses now the durable_file stead of a ffstream. Added checksum to each chunk to validate chunks separetly * feat : vtx crash recovery, create a .recovery file with only chunks, repairs the replay from the .recovery, it includes a test forcing a crash * feat : recovery fixes * feat : recovery replay completed * test: crash test recovery * test: crash test recovery * tests: commenting timeout tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds benchmarks/bench_crash_recovery.cpp, referenced by the CMakeLists that landed in #38/#39 - without it, configuring with -DVTX_BUILD_BENCHMARKS=ON fails on main.