Skip to content

Fix/votes api vercel entry - #50

Closed
LVLUP-tech wants to merge 2 commits into
ZeroPointRepo:mainfrom
LVLUP-tech:fix/votes-api-vercel-entry
Closed

LVLUP-tech wants to merge 2 commits into
ZeroPointRepo:mainfrom
LVLUP-tech:fix/votes-api-vercel-entry

Conversation

@LVLUP-tech

Copy link
Copy Markdown
Contributor

📕 Read CONTRIBUTING.md first — it's the rulebook (every
field, the quality bar, the Awesome Score). Reviewers cite it by rule number (G1–G8, UC-n, PL-n).

What this adds

Checklist

  • This PR adds exactly ONE new file under content/ (plus assets for this entry, if any).
  • It follows CONTRIBUTING.md — required fields + the golden rules (G1–G8).
  • npm run validate passes locally (schema, slug, vocabularies).
  • slug is kebab-case and exactly matches the filename.
  • I ran / used this myself end to end — it works today.
  • Every URL in the frontmatter resolves to real, relevant content.
  • The prompt body is the real, complete prompt — not a summary or a teaser.
  • The entry body is plain markdown — no raw HTML (<script>, <iframe>, <style>, <form>, inline event handlers). CI rejects it (§8.5).
  • I did NOT set verified_at or status: live — a maintainer sets those during verification (§10.1).
  • This is not an ad. A listing that exists to funnel traffic to your product gets closed. Sponsor slots will exist for that — this isn't one.
  • If this is someone else's work: author is the original creator, the origin is linked (source_url for a plugin, source_tweets[] for a use case), and scouted_by is me.
  • If the source is a YouTube video: primary_source is kind: youtube-video with a youtube.com/watch, youtu.be/ or youtube.com/shorts/ URL, plus the video's real title and channel — those two are required because they are what the page shows if the player never loads. timestamp is optional and is written mm:ss.
  • I license this contribution under CC BY 4.0 (attribution: entry author + grokbot.dev).

Where it came from

@scheemunai

Copy link
Copy Markdown
Contributor

Thanks for the PR @LVLUP-tech — I'm declining this one, with the specific reasons:

  1. Scope. Community PRs to this repo add content under content/ only (see CONTRIBUTING.md / CLAUDE.md). This one touches only CI and services/votes-api plumbing.

  2. The votes API is intentionally local-only. Per its RUNBOOK it's a P1 service bound to 127.0.0.1:4391 and exposed only through nginx on our own vhosts. api/index.ts + vercel.json would create a second, unmanaged public endpoint for a service that fronts the public submission form, session HMAC, Turnstile and the database. Nothing in the repo references Vercel today, so there was nothing broken to fix — this would be a new architecture, not a repair.

  3. Toolchain mismatch. .github/workflows/deno.yml runs deno lint / deno test -A against a Node/Astro repo with no Deno config — existing CI (ci.yml) runs node scripts plus astro check, so this workflow would fail on its first run and add red noise.

None of this is a judgement on the code quality — the adapter itself is written sensibly. If you hit an actual bug with the votes API or need a capability it doesn't have, please open an issue describing what you saw and we'll take a proper look.

Closing for now, and thanks again for the effort.

@scheemunai scheemunai closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants