Repository navigation
OsSocketAddr is unsound in upcoming rustc release #3
Description
This crate assumes that rust's SocketAddr types are implemented with the C layout, which is not guaranteed. It has generally happened to be true in the past, but this is no longer going to be true. I would suggest modifying the conversion trait implementations to get around this.
Activity
do not assume SocketAddr can be casted from/to sockaddr
do not assume SocketAddr is castable from/to sockaddr
do not assume SocketAddr is castable from/to sockaddr
a-ba commentedon Aug 26, 2022
thanks for the report
do not assume SocketAddr is castable from/to sockaddr
Noah-Kennedy commentedon Aug 26, 2022
Thanks for the response! I would also strongly recommend filing a rustsec advisory for the unpatched versions of this crate and potentially yanking unpatched versions as well, once this fix is released.
a-ba commentedon Aug 26, 2022
that was already in my todo list ;-)
Noah-Kennedy commentedon Aug 26, 2022
Awesome!
os_socketaddr was unsound and breaks newer Rust