Repository navigation
feat: add an interactive chat command - #86
Merged
Merged
Conversation
yarolegovich
left a comment
Member
There was a problem hiding this comment.
thanks for the PR! overall looks good, but I'd encourage to polish the overall chat UX further before merging it
Contributor
Author
|
I also took a stab at sending CancelTask when a turn is interrupted (663dd60), so the agent stops working on it too. Happy to roll it back if you'd rather keep that out of this PR. |
Member
|
@ConnorMoss02 Thank you for working on this. We appreciate this work :) I have shared a few comment to help with the help messages. |
…ut turns - A turn that exceeds --timeout now cancels the task it left running, instead of leaving it working while the next message starts a new task. - The cancel request after an interrupt gets its own interrupt scope, so a second Ctrl-C abandons it rather than waiting up to --timeout. - Without a terminal, chat prints the context and task ids after the single send so the conversation can be resumed. - The session logic lives in internal/chat; the cli package only wires the client into it. Input lines may be up to 1 MiB. - Tests follow the repository's conventions.
yarolegovich
approved these changes
Oct 28, 2026
Member
|
I'm going to apply @msampathkumar 's suggestions and merge. |
Without a terminal chat was a send with fewer options, so it is now a usage error that points to send. Help and flag text follow the review suggestions, and /exit ends a session like /quit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
a2a chat. It reads a message, sends it, prints the reply and loops. The context id carries across turns and an input-required task continues with your next message.--streamworks like it does forsend, and--context-idand--task-idpick up an existing conversation. Ctrl-C cancels a running turn, and a failed turn prints the error without ending the chat. It stops on auth-required and prints the ids on/quit, EOF or Ctrl-C at the prompt. When stdin or stdout isn't a terminal it sends once and exits.Fixes #34