Skip to content

fix(rest): format single-digit history length query #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 2 commits into from
Oct 6, 2026
Merged

fix(rest): format single-digit history length query #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0210f
fix(rest): format history length query parameter
014-code Oct 2, 2026
c0fc2e1
fix(rest): format history length query parameter for v0.3
014-code Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../transport/rest/src/main/java/org/a2aproject/sdk/client/transport/rest/RestTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public Task getTask(TaskQueryParams taskQueryParams, @Nullable ClientCallContext
try {
StringBuilder url = new StringBuilder(Utils.buildBaseUrl(agentInterface, taskQueryParams.tenant()));
if (taskQueryParams.historyLength() != null && taskQueryParams.historyLength() > 0) {
url.append(String.format("/tasks/%1s?historyLength=%2d", taskQueryParams.id(), taskQueryParams.historyLength()));
url.append(String.format("/tasks/%s?historyLength=%d", taskQueryParams.id(), taskQueryParams.historyLength()));
} else {
url.append(String.format("/tasks/%1s", taskQueryParams.id()));
}
Expand Down
3 changes: 2 additions & 1 deletion ...nsport/rest/src/test/java/org/a2aproject/sdk/client/transport/rest/RestTransportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,15 @@ public void testGetTask() throws Exception {
request()
.withMethod("GET")
.withPath("/tasks/de38c76d-d54c-436c-8b9f-4c2703648d64")
.withQueryStringParameter("historyLength", "5")
)
.respond(
response()
.withStatusCode(200)
.withBody(GET_TASK_TEST_RESPONSE)
);
ClientCallContext context = null;
TaskQueryParams request = new TaskQueryParams("de38c76d-d54c-436c-8b9f-4c2703648d64", 10);
TaskQueryParams request = new TaskQueryParams("de38c76d-d54c-436c-8b9f-4c2703648d64", 5);
RestTransport instance = new RestTransport(CARD);
Task task = instance.getTask(request, context);
assertEquals("de38c76d-d54c-436c-8b9f-4c2703648d64", task.id());
Expand Down
2 changes: 1 addition & 1 deletion ...t/src/main/java/org/a2aproject/sdk/compat03/client/transport/rest/RestTransport_v0_3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public Task_v0_3 getTask(TaskQueryParams_v0_3 taskQueryParams, @Nullable ClientC
try {
String url;
if (taskQueryParams.historyLength() > 0) {
url = agentUrl + String.format("/v1/tasks/%1s?historyLength=%2d", taskQueryParams.id(), taskQueryParams.historyLength());
url = agentUrl + String.format("/v1/tasks/%s?historyLength=%d", taskQueryParams.id(), taskQueryParams.historyLength());
} else {
url = agentUrl + String.format("/v1/tasks/%1s", taskQueryParams.id());
}
Expand Down
3 changes: 2 additions & 1 deletion .../test/java/org/a2aproject/sdk/compat03/client/transport/rest/RestTransport_v0_3_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,15 @@ public void testGetTask() throws Exception {
request()
.withMethod("GET")
.withPath("/v1/tasks/de38c76d-d54c-436c-8b9f-4c2703648d64")
.withQueryStringParameter("historyLength", "5")
)
.respond(
response()
.withStatusCode(200)
.withBody(GET_TASK_TEST_RESPONSE)
);
ClientCallContext_v0_3 context = null;
TaskQueryParams_v0_3 request = new TaskQueryParams_v0_3("de38c76d-d54c-436c-8b9f-4c2703648d64", 10);
TaskQueryParams_v0_3 request = new TaskQueryParams_v0_3("de38c76d-d54c-436c-8b9f-4c2703648d64", 5);
RestTransport_v0_3 instance = new RestTransport_v0_3(CARD);
Task_v0_3 task = instance.getTask(request, context);
assertEquals("de38c76d-d54c-436c-8b9f-4c2703648d64", task.id());
Expand Down
Loading