Repository navigation
fix: cancel in-flight REST streaming futures on close - #1202
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Track active REST streaming futures in both protocol implementations, remove completed futures, and cancel pending futures when closing. Cover completion, shutdown races, idempotence, and JDK socket release. Related: a2aproject#1194
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closing a REST transport now cancels its pending HTTP streaming futures in both native and 0.3 compatibility clients. With the default JDK HTTP provider, this also releases open SSE connections, including when close races with stream setup.
Normal EOF completion notification is deferred because the current error-handler API expects a non-null Throwable. Optional Vert.x and Android providers do not currently propagate future cancellation to their underlying network streams; this change does not add those provider hooks. Borrowed HTTP clients remain caller-owned.
Related: #1194
Validation
Contribution checklist