Skip to content

build: enforce existing Checkstyle rules - #1208

Open
ZYZ666-RGB wants to merge 1 commit into
a2aproject:mainfrom
ZYZ666-RGB:issue-1206
Open

ZYZ666-RGB wants to merge 1 commit into
a2aproject:mainfrom
ZYZ666-RGB:issue-1206

Conversation

@ZYZ666-RGB

Copy link
Copy Markdown

Description

Checkstyle currently reports violations without failing validation. Enable checkstyle.failOnViolation=true and clean up the existing trailing whitespace and unused imports so the current rules can be enforced.

The Java changes are limited to whitespace and unused imports, including checked-in protobuf/gRPC sources. The Checkstyle rules and source coverage remain unchanged.

Validation

  • Checkstyle 9.3 with the repository configuration: all 1,132 tracked Java files pass, with zero violations.
  • mvn -o -pl spec validate passes after removing the temporary probes.
  • Four isolated negative checks confirm that trailing whitespace and unused imports each fail Maven validation in both production and test sources. No probe files are included in the commit.
  • git diff --check passes with CRLF handling enabled; the existing CRLF file is preserved.

The previous October 8 verification passed validation across all 83 reactor modules. The full test run reported four failures and one error in OpenTelemetry tests; the same cases were reproduced using unmodified baseline sources. Docker-dependent tests were skipped. A fresh full build on October 9 did not complete in the recreated environment, so a fully green test suite is not claimed; repository CI should provide that confirmation.

  • Followed the CONTRIBUTING Guide.
  • Used a Conventional Commit PR title.
  • Ensure the full test suite passes (limitations described above).
  • Appropriate READMEs updated if necessary (not applicable to this change).

Fixes #1206

Fail validation when existing Checkstyle rules find violations. Remove trailing whitespace and unused imports from checked Java sources.

This fixes a2aproject#1206

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable checkstyle failOnViolation=true

1 participant