Repository navigation
build: enforce existing Checkstyle rules - #1208
Open
ZYZ666-RGB wants to merge 1 commit into
Open
ZYZ666-RGB wants to merge 1 commit into
ZYZ666-RGB wants to merge 1 commit into
Conversation
Fail validation when existing Checkstyle rules find violations. Remove trailing whitespace and unused imports from checked Java sources. This fixes a2aproject#1206
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checkstyle currently reports violations without failing validation. Enable
checkstyle.failOnViolation=trueand clean up the existing trailing whitespace and unused imports so the current rules can be enforced.The Java changes are limited to whitespace and unused imports, including checked-in protobuf/gRPC sources. The Checkstyle rules and source coverage remain unchanged.
Validation
mvn -o -pl spec validatepasses after removing the temporary probes.git diff --checkpasses with CRLF handling enabled; the existing CRLF file is preserved.The previous October 8 verification passed validation across all 83 reactor modules. The full test run reported four failures and one error in OpenTelemetry tests; the same cases were reproduced using unmodified baseline sources. Docker-dependent tests were skipped. A fresh full build on October 9 did not complete in the recreated environment, so a fully green test suite is not claimed; repository CI should provide that confirmation.
Fixes #1206