test: build itk instruction proto straight from repository and remove local copy#992
test: build itk instruction proto straight from repository and remove local copy#992JakubWorek wants to merge 3 commits into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
| # the external `a2a-itk` repo and are fetched at test time by | ||
| # `itk/run_itk.sh`. It is exercised by the dedicated `itk.yaml` and | ||
| # `itk-nightly.yaml` workflows instead. | ||
| run: mvn -B package --file pom.xml -fae -pl '!itk' ${{ matrix.os == 'windows-latest' && '-DskipDockerTests=true' || '' }} |
There was a problem hiding this comment.
@JakubWorek I wonder if instead of having to specify -pl !itk in all the GH Actions workflow files, if it might be better to change the parent pom so that the itk module is included in the list of modules, and have a 'itk' profile to enable it?
That will save adjusting all the jobs. We also have other repositories consuming this module, which in some cases need to build a SNAPSHOT of a2a-java, so this will have knock-on effects
There was a problem hiding this comment.
I agree with @kabir: Why not create a itk profile disabled by default in the parent pom that would add the itk module ? So you just enable it in the ITK workflow
There was a problem hiding this comment.
ack, I'll adjust the solution
There was a problem hiding this comment.
done, now itk pipeline wont be green until a2aproject/a2a-itk#26 lands
11af5c0 to
d90c35d
Compare
| -Da2a.itk.proto.dir=... when building outside run_itk.sh. | ||
| --> | ||
| <a2a.itk.proto.dir>${project.basedir}/a2a-itk/protos</a2a.itk.proto.dir> | ||
| <protobuf-maven-plugin.version>4.1.2</protobuf-maven-plugin.version> |
There was a problem hiding this comment.
This is now managed by the parent pom
There was a problem hiding this comment.
thank you, I'll adjust to latest main branch
15707cf to
e0d0494
Compare
3 participants
Description
Adjusts itk pipeline to use instruction proto straight from cloned itk repository during startup of itk test