Skip to content

[Bug]: Align send_message signature for BaseClient and Client #727

Closed

Description

@guglielmo-san

What happened?

The current signature of the send_message method, differs from the Client interface

async def send_message(
self,
request: Message,
*,
context: ClientCallContext | None = None,
request_metadata: dict[str, Any] | None = None,
extensions: list[str] | None = None,

and the BaseClient implementation

async def send_message(
self,
request: Message,
*,
configuration: MessageSendConfiguration | None = None,
context: ClientCallContext | None = None,
request_metadata: dict[str, Any] | None = None,
extensions: list[str] | None = None,

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Activity

  1. Akshat8510 commented on Feb 24, 2026

    @Akshat8510
    Contributor

    I’d like to work on this.

    Proposed Solution:
    I will align the send_message signature in src/a2a/client/client.py with the BaseClient implementation by adding the configuration: MessageSendConfiguration | None = None keyword-only argument. I will also ensure that MessageSendConfiguration is correctly imported in the abstract class to maintain type-hint consistency.

    Please assign this to me.

  2. self-assigned this
    on Feb 25, 2026
  3. added
    component: clientIssues related to transport logic and configuration for external apps connecting to A2A agents.
    on Feb 25, 2026
  4. ishymko commented on Feb 25, 2026

    @ishymko
    Member

    Thanks @Akshat8510 for your interest, please create your PR into 1.0-dev branch.

  5. added
    component: clientIssues related to transport logic and configuration for external apps connecting to A2A agents.
    and removed
    component: clientIssues related to transport logic and configuration for external apps connecting to A2A agents.
    on Feb 25, 2026
  6. Akshat8510 commented on Feb 25, 2026

    @Akshat8510
    Contributor

    sry forgot that 1.0 dev part : )

  7. Akshat8510 commented on Feb 25, 2026

    @Akshat8510
    Contributor

    Hi @ishymko, I have submitted the PR to the 1.0-dev branch as requested.

  8. added a commit that references this issue on Feb 27, 2026
    57cb529
  9. ishymko commented on Mar 2, 2026

    @ishymko
    Member

    Fixed in 1.0-dev via #740.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

component: clientIssues related to transport logic and configuration for external apps connecting to A2A agents.

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions