You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently client does not reconstruct domain errors and errors are different in different transports: rest.py, jsonrpc.py, no special logic in grpc.py so likely it's going to throw gRPC library errors.
With 1.0 specifying error format for HTTP+JSON/REST (#722) and GRPC (#723) it's a good opportunity for implementing proper transport agnostic errors on the client.
Server
Currently server defines domain errors, however built-in ValueError's are used there as well, i.e. here. This error is not mapped to 400-ish invalid request error in JSON-RPC and is converted to internal error: jsonrpc_handler.py and jsonrpc_app.py. Same for REST: error_handlers.py.
This seems like a broad task. Would you prefer I ( if get assign to this ) start with the Server side (mapping ValueError to specific domain errors and updating the JSON-RPC/REST handlers) or the Client side (unifying the transport errors into domain exceptions)?
At this time we're not accepting external contributions for 1.0-related issues due to coordination overhead and priority of this work. And as you correctly pointed out it's broadly defined at the moment and requires some refinement.
I'll be explicit and add proper label to avoid confusion.
Hey @Akshat8510 sorry for the late reply, appreciate your interest! We're currently focusing on 1.0 readiness so the bandwidth for community engagement has reduced unfortunately. Things should improve over the course of a few weeks, should have more GFI's :)
Activity
Akshat8510 commentedon Feb 27, 2026
Hi @ishymko, I'd like to help with the error handling improvements.
Akshat8510 commentedon Feb 27, 2026
This seems like a broad task. Would you prefer I ( if get assign to this ) start with the Server side (mapping
ValueErrorto specific domain errors and updating the JSON-RPC/REST handlers) or the Client side (unifying the transport errors into domain exceptions)?ishymko commentedon Mar 2, 2026
Hi @Akshat8510, thanks for volunteering!
At this time we're not accepting external contributions for 1.0-related issues due to coordination overhead and priority of this work. And as you correctly pointed out it's broadly defined at the moment and requires some refinement.
I'll be explicit and add proper label to avoid confusion.
Akshat8510 commentedon Mar 2, 2026
okay i understand completely :)
Akshat8510 commentedon Mar 2, 2026
I’m currently exploring the codebase. If there are any beginner-friendly issues (gfi), feel free to tag me , I am happy to work in this repo
refactor(server): remove ServerError wrapper
refactor(server): remove ServerError wrapper
refactor(server): remove ServerError wrapper
refactor(server): remove ServerError wrapper
refactor(server): remove ServerError wrapper (#755)
refactor(client): map error responses to domain errors
refactor(client): map error responses to domain errors (#761)
ishymko commentedon Mar 6, 2026
Hey @Akshat8510 sorry for the late reply, appreciate your interest! We're currently focusing on 1.0 readiness so the bandwidth for community engagement has reduced unfortunately. Things should improve over the course of a few weeks, should have more GFI's :)
ishymko commentedon Mar 6, 2026
Done for
1.0-devvia #755 and #761.Akshat8510 commentedon Mar 6, 2026
that's great @ishymko , thanks for informing :)