Skip to content

[Task]: Improve error handling #737

Description

@ishymko

Client

Currently client does not reconstruct domain errors and errors are different in different transports: rest.py, jsonrpc.py, no special logic in grpc.py so likely it's going to throw gRPC library errors.

With 1.0 specifying error format for HTTP+JSON/REST (#722) and GRPC (#723) it's a good opportunity for implementing proper transport agnostic errors on the client.

Server

Currently server defines domain errors, however built-in ValueError's are used there as well, i.e. here. This error is not mapped to 400-ish invalid request error in JSON-RPC and is converted to internal error: jsonrpc_handler.py and jsonrpc_app.py. Same for REST: error_handlers.py.

Activity

  1. added theissue type on Feb 25, 2026
  2. Akshat8510 commented on Feb 27, 2026

    @Akshat8510
    Contributor

    Hi @ishymko, I'd like to help with the error handling improvements.

  3. Akshat8510 commented on Feb 27, 2026

    @Akshat8510
    Contributor

    This seems like a broad task. Would you prefer I ( if get assign to this ) start with the Server side (mapping ValueError to specific domain errors and updating the JSON-RPC/REST handlers) or the Client side (unifying the transport errors into domain exceptions)?

  4. ishymko commented on Mar 2, 2026

    @ishymko
    MemberAuthor

    Hi @Akshat8510, thanks for volunteering!

    At this time we're not accepting external contributions for 1.0-related issues due to coordination overhead and priority of this work. And as you correctly pointed out it's broadly defined at the moment and requires some refinement.

    I'll be explicit and add proper label to avoid confusion.

  5. Akshat8510 commented on Mar 2, 2026

    @Akshat8510
    Contributor

    okay i understand completely :)

  6. Akshat8510 commented on Mar 2, 2026

    @Akshat8510
    Contributor

    I’m currently exploring the codebase. If there are any beginner-friendly issues (gfi), feel free to tag me , I am happy to work in this repo

  7. ishymko commented on Mar 6, 2026

    @ishymko
    MemberAuthor

    Hey @Akshat8510 sorry for the late reply, appreciate your interest! We're currently focusing on 1.0 readiness so the bandwidth for community engagement has reduced unfortunately. Things should improve over the course of a few weeks, should have more GFI's :)

  8. ishymko commented on Mar 6, 2026

    @ishymko
    MemberAuthor

    Done for 1.0-dev via #755 and #761.

  9. linked a pull request that will close this issuerefactor(server): remove ServerError wrapper #755on Mar 6, 2026
  10. Akshat8510 commented on Mar 6, 2026

    @Akshat8510
    Contributor

    that's great @ishymko , thanks for informing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions