Skip to content

fix(compat): block on a v0.3 gRPC and REST send without configuration #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Iwaniukooo11 merged 2 commits into from
Oct 14, 2026
Merged

fix(compat): block on a v0.3 gRPC and REST send without configuration #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b836cc5
fix(compat): block on a v0.3 gRPC and REST send without configuration
ConnorMoss02 Oct 12, 2026
4f050f3
Merge branch 'main' into fix/v03-missing-configuration-blocks
Iwaniukooo11 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/a2a/compat/v0_3/proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,9 @@ def message_send_params(
cls, request: a2a_pb2.SendMessageRequest
) -> types.MessageSendParams:
return types.MessageSendParams(
configuration=cls.message_send_configuration(request.configuration),
configuration=cls.message_send_configuration(request.configuration)
if request.HasField('configuration')
else None,
message=cls.message(request.request),
metadata=cls.metadata(request.metadata),
)
Expand Down
3 changes: 0 additions & 3 deletions tests/compat/v0_3/test_grpc_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ async def test_send_message_success_task(
message=a2a_pb2.Message(
message_id='msg-1', role=a2a_pb2.Role.ROLE_USER
),
configuration=a2a_pb2.SendMessageConfiguration(return_immediately=True),
)
mock_request_handler.on_message_send.assert_called_once_with(
expected_req, ANY
Expand Down Expand Up @@ -113,7 +112,6 @@ async def test_send_message_success_message(
message=a2a_pb2.Message(
message_id='msg-1', role=a2a_pb2.Role.ROLE_USER
),
configuration=a2a_pb2.SendMessageConfiguration(return_immediately=True),
)
mock_request_handler.on_message_send.assert_called_once_with(
expected_req, ANY
Expand Down Expand Up @@ -164,7 +162,6 @@ async def mock_stream(*args, **kwargs):
message=a2a_pb2.Message(
message_id='msg-1', role=a2a_pb2.Role.ROLE_USER
),
configuration=a2a_pb2.SendMessageConfiguration(return_immediately=True),
)
mock_request_handler.on_message_send_stream.assert_called_once_with(
expected_req, ANY
Expand Down
7 changes: 7 additions & 0 deletions tests/compat/v0_3/test_proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,13 @@ def test_message_send_configuration_history_length(
)
assert config.history_length == expected

def test_message_send_params_without_configuration(self):
"""An unset configuration stays None so the send defaults to blocking."""
params = proto_utils.FromProto.message_send_params(
a2a_pb2.SendMessageRequest(request=a2a_pb2.Message(message_id='m'))
)
assert params.configuration is None

def test_none_handling(self):
"""Test that None inputs are handled gracefully."""
assert proto_utils.ToProto.message(None) is None
Expand Down
Loading