Conversation
Greptile SummaryThis PR adds Codex as a supported host target alongside the existing Claude Code path. The All four issues flagged in the previous review round have been addressed:
One minor issue remains: the dry-run stale-files error message in Confidence Score: 5/5PR is safe to merge; all four previously-identified blocking issues are resolved and only a minor UX inaccuracy in the dry-run error message remains All P1 findings from the prior review round are fully addressed. The sole remaining finding is a P2 UX issue where the dry-run stale-files error message omits --host codex, which does not affect correctness, data integrity, or the actual generation/linking logic. scripts/gen-skill-docs.ts has the minor dry-run message inaccuracy noted above; no other files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[setup --host codex] --> B{migrate_direct_codex_install}
B -->|moved SOURCE_EMDASH_DIR| C[Recompute CODEX_GENERATED_SKILLS_DIR]
B -->|no migration needed| D[generate_codex_skill_docs]
C --> D
D --> E[bun run gen:skill-docs -- --host codex]
E --> F[Write SKILL.md + agents/openai.yaml\ninto CODEX_OUTPUT_ROOT per skill]
F --> G{CODEX_REPO_LOCAL?}
G -->|yes: inside .agents/skills/| H[CODEX_SKILLS = .agents/skills]
G -->|no: global install| I[create_codex_runtime_root\n~/.codex/skills/em-dash]
H --> J[link_codex_skill_dirs]
I --> J
J --> K[Symlink each skill dir from CODEX_SKILLS]
K --> L[em-dash ready - codex]
Reviews (4): Last reviewed commit: "fix: implement --host codex in gen-skill..." | Re-trigger Greptile |
Add --host flag to setup script supporting both Claude and Codex targets. Codex gets its own skill directory (~/.codex/skills) with host-appropriate skill files. Includes generation, setup, and smoke tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sts to CI - Implement Codex generation path in gen-skill-docs.ts: --host flag, frontmatter stripping, .claude→.codex/.agents path rewriting, agents/openai.yaml emission, dry-run support - Fix stale CODEX_GENERATED_SKILLS_DIR after migrate_direct_codex_install - Remove unused emdash_dir param from link_codex_skill_dirs - Pass EMDASH_CODEX_OUTPUT_ROOT in smoke test to avoid source tree pollution - Add codex test files to package.json test script Addresses: P0 missing codex generator, P1 stale path after migration, P1 tests not in CI, P2 smoke test pollution, P2 dead parameter Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
160377d to
2f1d7c9
Compare
Summary
--hostflag tosetupscript supporting bothclaudeandcodextargets~/.codex/skills) with host-appropriate skill filesTest plan
bun test test/codex-generation.test.tsbun test test/codex-setup.test.tsbun test test/codex-smoke.test.ts./setup --host codexinstalls to~/.codex/skills/em-dash./setup --host claudestill works as before🤖 Generated with Claude Code