Repository navigation
The family's foot: the home page's line - #408
Merged
Merged
Conversation
CONVENTION.md section 5 in abap2UI5/abap2UI5.github.io: every site carries the home page's foot, the licence and About, and nothing more. The manual had "License | Contact" and a copyright line. It now has "MIT licensed" (to the licence) and "About" (the home page's, target="_self" so the router does not take it over), in the default theme's own footer. check:cross-site knew the home deployment only as "/". It now also names "/about/", matched exactly like the root. The test pins both the page and that it is not a prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmEpRdxrjNxTq4x9J4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONVENTION.md section 5 in abap2UI5/abap2UI5.github.io now says every site carries the home page's foot: the licence and About, nothing more. Samples and Addons already do (abap2UI5/samples-site#17, abap2UI5-addons/abap2UI5-addons.github.io#32).
What changes
target="_self"). It stays in the default theme's own footer, so no theme part is restyled.check:cross-site: it knew the home deployment only as/, so it rejected the 137 new About links. It now also names/about/, matched exactly like the root (HOME_PAGES).test/cross-site.test.mjspins both the page and that it is not a prefix (/about/team/is still refused).Tests
npm run checkis green, all fifteen gates. Two notes:check:samplesskipped itself here because no samples checkout was present.npm test: 180 pass.Generated by Claude Code