Match CocoaPods names exactly when reading version lists - #206
Open
codewithfourtix wants to merge 2 commits into
Open
Match CocoaPods names exactly when reading version lists#206codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The updated “no exact match” behavior can propagate None to callers that iterate tags (e.g., CocoaPods route code), causing a runtime TypeError instead of safely yielding no results.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR fixes CocoaPods version-list parsing to avoid selecting the wrong pod when one pod name is a prefix of another (e.g., Foo vs FooBar) by requiring an exact field match when scanning the versions index.
Changes:
- Update CocoaPods version-line matching to require
"{name}/"instead of a plain prefix match. - Add tests covering overlapping-name scenarios and the “no exact match” case.
File summaries
| File | Description |
|---|---|
| tests/test_cocoapods_tag_lookup.py | Adds focused tests for overlapping CocoaPods names and missing exact matches. |
| src/fetchcode/package_util.py | Tightens get_cocoapod_tags() matching to avoid prefix collisions. |
Review details
Suppressed comments (1)
src/fetchcode/package_util.py:304
get_cocoapod_tags()can returnNone(no exact match or exception). The primary callerget_cocoapods_data_from_purl()iteratesfor tag in data_listwithout checking forNone, so a missing pod entry will now raiseTypeError: 'NoneType' object is not iterableinstead of cleanly yielding no results. Consider making this helper always return a list (empty when not found / on error) and avoid the bareexcept:(it also catchesKeyboardInterrupt/SystemExit).
if line.startswith(name + "/"):
data_list = line.split("/")
if data_list[0] == name:
data_list.pop(0)
return data_list
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+11
to
+13
| def test_cocoapod_tags_return_none_when_only_prefix_matches(monkeypatch): | ||
| monkeypatch.setattr("fetchcode.utils.get_text_response", lambda url: "FooBar/9.0\n") | ||
| assert get_cocoapod_tags("https://example.com/versions", "Foo") is None |
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking up
Foocan return the versions ofFooBarbecause the lookup only checks the name prefix. Include the field separator in the match so only the requested pod is selected.Adds tests with an overlapping name and with no exact match.