Fix/replace log.Fatal with error propagation in library init and fix file leak - #13
Open
krisharma955 wants to merge 2 commits into
Open
Conversation
Handle the error returned by os.ReadFile() in insert_purls instead of discarding it with _. Previously, if a data file could not be read, zero PURLs were silently inserted into the FST with no indication of failure. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com> Signed-off-by: krishsharma955 <krishsharma9005@gmail.com>
… leak Replace init() with sync.Once lazy initialization in purlvalidator.go so the library no longer crashes consumers on FST load failure. Add defer f.Close() in cmd/main.go to prevent file descriptor leak. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com> Signed-off-by: krishsharma955 <krishsharma9005@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
purlvalidator.go: The library'sinit()function calledlog.Fatal()if the embedded FST failed to load, which crashes any program that imports this package with no way for the caller to handle the error. Replaced with lazysync.Onceinitialization soValidate()returns(false, error)instead of terminating the process.cmd/main.go: Addeddefer f.Close()afteros.Create("purls.fst")to prevent a file descriptor leak.Changes
purlvalidator.go: Removedinit()withlog.Fatal, addedgetValidator()usingsync.Oncefor thread-safe lazy initialization. Public API (Validate) unchanged.cmd/main.go: Addeddefer f.Close()after file creation.