Skip to content

Fix absl_stacktrace_test on s390x#2051

Closed
miladfarca wants to merge 1 commit into
abseil:masterfrom
miladfarca:fix-33bbc26
Closed

Fix absl_stacktrace_test on s390x#2051
miladfarca wants to merge 1 commit into
abseil:masterfrom
miladfarca:fix-33bbc26

Conversation

@miladfarca
Copy link
Copy Markdown
Contributor

Commit 33bbc26 made changes to stacktrace_emscripten-inl.inc but did not change the stacktrace_generic-inl.inc file. This caused absl_stacktrace_test to fail on s390x.

Expected: (results[i]) != (nullptr), actual: NULL vs (nullptr)
Unexpected nullptr found at index 14

[  FAILED  ] StackTrace.NoNullptrInPopulatedRange (0 ms)

This patch applies the same logic to stacktrace_generic-inl.inc.

@miladfarca
Copy link
Copy Markdown
Contributor Author

/cc @derekmauro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants