Skip to content

reject oversize punycode length in rust demangler #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabhan06 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

reject oversize punycode length in rust demangler #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions absl/debugging/internal/demangle_rust.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,11 @@ class RustSymbolParser {
if (!ParseDecimalNumber(num_bytes)) return false;
(void)Eat('_'); // optional separator, needed if a digit follows
if (is_punycoded) {
// A length exceeding the remaining input would make punycode_end point
// past the end of the buffer, forming an out-of-bounds pointer.
if (static_cast<size_t>(num_bytes) > std::strlen(&encoding_[pos_])) {
return false;
}
DecodeRustPunycodeOptions options;
options.punycode_begin = &encoding_[pos_];
options.punycode_end = &encoding_[pos_] + num_bytes;
Expand Down
5 changes: 5 additions & 0 deletions absl/debugging/internal/demangle_rust_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ TEST(DemangleRust, UnicodeIdentifiers) {
"ice_cap::Eyjafjallajökull");
EXPECT_DEMANGLING("_RNvC7ice_caps_u19Eyjafjallajkull_jtb",
"ice_cap::Eyjafjallajökull");

// A punycode byte count larger than the remaining input is rejected instead
// of running the decoder past the end of the buffer.
EXPECT_DEMANGLING_FAILS("_RNvC7ice_caps_u2000000000Eyjafjallajkull_jtb");
EXPECT_DEMANGLING_FAILS("_RNvC7ice_caps_u99Eyj_a");
}

TEST(DemangleRust, FunctionInModule) {
Expand Down