Repository navigation
fix(markdown-common): preserve non-default ordered list boundaries - #686
Open
YashAnand69 wants to merge 1 commit into
Open
YashAnand69 wants to merge 1 commit into
YashAnand69 wants to merge 1 commit into
Conversation
Signed-off-by: Yash Anand <164618230+YashAnand69@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313
Changes
Roundtripping a paragraph followed by
5. First itemdrops the separating blank line. CommonMark then parses the numbered text as part of the paragraph, so the list disappears. Preserve that separator before the first item of an ordered list whose start is not 1. Default-start lists retain their existing output.Added regressions for paragraph, blockquote and nested-list boundaries, zero/document-start lists and non-list numerals, plus a browser test through the public transform API.
Validation
Flags
Validation used Node 24.13.0 initially and was independently repeated on Node 24.19.0. Other browser engines were not exercised.
Codex assisted with investigation, implementation and regression tests; the full diff and validation results were independently reviewed.
Related Issues
Author Checklist