Add Sandeep Kuttal webinar recording and Fix action issues - #152
Merged
Merged
Conversation
yqtian-se
changed the title
Contributor
Author
|
also fix the acition issues by updating the workflows for Node.js 24 compatibility and securely separating pull request preview builds from privileged deployments. |
CaptainEmerson
approved these changes
Sep 24, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The privileged deployment trusts a PR-controlled artifact for its target pull request number.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds Sandeep Kuttal’s webinar recording and secures the GitHub Pages preview process by separating unprivileged builds from privileged deployments.
Changes:
- Adds the webinar’s YouTube recording.
- Splits preview building and deployment into separate workflows.
- Updates GitHub Actions versions and artifact packaging.
| File | Description |
|---|---|
README.md |
Documents the preview workflows. |
content/activities/webinarsmain.md |
Adds the webinar recording link. |
.github/workflows/production-deploy.yml |
Updates actions and artifact handling. |
.github/workflows/pr-preview.yml |
Creates read-only preview artifacts. |
.github/workflows/pr-preview-deploy.yml |
Deploys previews and comments their URLs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+52
to
+63
| - name: Validate deployment metadata | ||
| id: metadata | ||
| env: | ||
| PREVIEW_ROOT: ${{ runner.temp }}/preview | ||
| SITE_BASE_URL: ${{ steps.pages.outputs.base_url }} | ||
| run: | | ||
| test -d "$PREVIEW_ROOT/preview-public" | ||
| test -f "$PREVIEW_ROOT/metadata/pr-number" | ||
| grep -Eq '^[1-9][0-9]*$' "$PREVIEW_ROOT/metadata/pr-number" | ||
| PR_NUMBER="$(tr -d '\r\n' < "$PREVIEW_ROOT/metadata/pr-number")" | ||
| printf 'pr_number=%s\n' "$PR_NUMBER" >> "$GITHUB_OUTPUT" | ||
| printf 'preview_url=%s/pr-%s\n' "$SITE_BASE_URL" "$PR_NUMBER" >> "$GITHUB_OUTPUT" |
| There are two GitHub Actions workflows defined in the `.github/workflows` directory: | ||
| - `pr-preview.yml`: This workflow is triggered on pull requests and deploys the website to a temporary URL. | ||
| - `pr-preview.yml`: This read-only workflow builds preview artifacts for pull requests. | ||
| - `pr-preview-deploy.yml`: This workflow deploys successful preview artifacts and adds the preview URL to the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.