chore: add extraPermissions to generate action.yml#316
chore: add extraPermissions to generate action.yml#316sekhar-isovalent wants to merge 1 commit intoactions:mainfrom
Conversation
|
@gr2m - FYI. Appreciate if this can be integrated. |
Signed-off-by: Sekhar Sankaramanchi <sekhar@isovalent.com>
585d73b to
c00544e
Compare
parkerbxyz
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The missing permissions are a real pain point (as noted in #310 and #231).
I'd prefer to avoid hard-coding extraPermissions in the generator script though, since it could drift again as new permissions are added upstream.
The root cause is that the OpenAPI override files in octokit/openapi have fallen out of sync with the actual API. There's an open PR to start addressing that: octokit/openapi#529. Once the overrides are resynced upstream, the generator should pick up attestations, variables, organization-variables, and any other missing permissions automatically.
I'd prefer to fix this at the source rather than maintain a hardcoded list here, so I'm going to close this in favor of the upstream fix.
add extraPermissions to add
permissions-variablesandpermissions-attestationsas generator based on openapi spec is brokenFixes:
#310
#231