Skip to content

chore: add extraPermissions to generate action.yml#316

Closed
sekhar-isovalent wants to merge 1 commit intoactions:mainfrom
sekhar-isovalent:main
Closed

chore: add extraPermissions to generate action.yml#316
sekhar-isovalent wants to merge 1 commit intoactions:mainfrom
sekhar-isovalent:main

Conversation

@sekhar-isovalent
Copy link
Copy Markdown

@sekhar-isovalent sekhar-isovalent commented Dec 11, 2025

add extraPermissions to add permissions-variables and permissions-attestations as generator based on openapi spec is broken

Fixes:

#310
#231

@sekhar-isovalent sekhar-isovalent requested a review from a team as a code owner December 11, 2025 11:52
@sekhar-isovalent
Copy link
Copy Markdown
Author

@gr2m - FYI. Appreciate if this can be integrated.

Signed-off-by: Sekhar Sankaramanchi <sekhar@isovalent.com>
Copy link
Copy Markdown
Contributor

@parkerbxyz parkerbxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The missing permissions are a real pain point (as noted in #310 and #231).

I'd prefer to avoid hard-coding extraPermissions in the generator script though, since it could drift again as new permissions are added upstream.

The root cause is that the OpenAPI override files in octokit/openapi have fallen out of sync with the actual API. There's an open PR to start addressing that: octokit/openapi#529. Once the overrides are resynced upstream, the generator should pick up attestations, variables, organization-variables, and any other missing permissions automatically.

I'd prefer to fix this at the source rather than maintain a hardcoded list here, so I'm going to close this in favor of the upstream fix.

@parkerbxyz parkerbxyz closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants