fix(protocol): require integer retry_after emission - #6165
Merged
Conversation
bokelley
marked this pull request as ready for review
August 3, 2026 14:37
Contributor
There was a problem hiding this comment.
Ladon verdict: Request changes
Request changes — 1 blocking finding.
Blocking findings
- static/schemas/source/core/error.json:27 —
retry_aftertype narrowed fromnumbertointeger, a backward-incompatible wire tightening shipped on a minor changeset. A field released in 3.1.x is having its value domain narrowed; a producer that previously emitted a fractionalretry_afternow emits an invalid value against the tightened schema, breaking conformant 3.1 implementations. Per the changeset-scope rule, a breaking wire change (type narrowing / value-domain restriction on a published field) requires amajorchangeset, not a minor. This is also a Breaking-class protocol change under the constitution's decision classes, which is never auto-approved without human ratification.
The schema↔docs coherence, ceil-before-clamp migration prose, JS example, and regression test are all internally consistent and correct — the sole concern is the release sizing of the breaking narrowing.
Note: this PR also touches gated paths (static/schemas/source/**) with review_decision: REVIEW_REQUIRED, so it additionally requires human/CODEOWNERS approval before merge.
Row 1 of the decision table (a high finding present) governs: outcome is request-changes.
Blocking findings
- static/schemas/source/core/error.json:27 — retry_after number -> integer is a breaking type narrowing shipped as minor; breaking wire changes require a major changeset and human ratification
bokelley
dismissed
aao-secretariat[bot]’s stale review
August 8, 2026 05:06
The number-to-integer schema narrowing was removed in dbdee3e; the released numeric wire type is preserved. Dismissing the stale blocking review pending current-head review.
bokelley
enabled auto-merge (squash)
August 8, 2026 05:07
bokelley
disabled auto-merge
August 8, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines deterministic integer
error.retry_afteremission for AdCP 3.2 without narrowing the released 3.x wire schema.The migration rule is ceiling before clamping:
Preserving the JSON Schema
numbertype keeps earlier conformant payloads valid. The normative producer requirement supplies the 3.2 behavior, and the consumer rule prevents early retries during migration.Closes #5953.
Changes
Validation
git diff --check: passed