Skip to content

feat(compliance): cover three missing tasks - #6172

Merged
bokelley merged 4 commits into
mainfrom
feat/three-missing-task-storyboards
Aug 8, 2026
Merged

feat(compliance): cover three missing tasks#6172
bokelley merged 4 commits into
mainfrom
feat/three-missing-task-storyboards

Conversation

@bokelley

@bokelley bokelley commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Restores the bounded, reviewable slice from closed PR #4294 on a clean branch based on main:

  • search_brands on the existing brand protocol storyboard
  • get_creative_features on the existing content-standards storyboard
  • get_media_buy_artifacts on the existing content-standards storyboard, with controller-seeded buy state

Each task is gated with step-level requires_tool, so agents that do not advertise an experimental task receive missing_tool rather than failing the whole storyboard. None were added to storyboard-level required_tools.

The review follow-up also fixes both dangling doc_ref values: get_creative_features now points to its governance task page, and search_brands now has a task reference included in live navigation.

Verification

  • compliance source build passes (41 universal, 6 protocol, 21 specialism storyboards)
  • sample-request, response-schema, and validation-path lints pass
  • changed storyboard YAML parses successfully
  • documentation navigation includes the new page and both referenced pages exist
  • changeset protocol scope passes
  • git diff --check passes

Part of #4291. Remaining umbrella tracks are split into focused follow-ups.

Comment thread static/compliance/source/specialisms/content-standards/index.yaml Outdated
Comment thread static/compliance/source/protocols/brand/index.yaml
aao-secretariat[bot]
aao-secretariat Bot previously approved these changes Aug 3, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — additive compliance coverage restoring three experimental-task storyboard steps (search_brands, get_creative_features, get_media_buy_artifacts).

Checked: sample requests conform to request-schema required fields; validation paths (brands, results, artifacts, media_buy_id) match the response schemas; controller_seeding placement (under prerequisites) and top-level fixtures.media_buys match the established media-buy scenario pattern; changeset is minor, appropriate for additive coverage. No wire-shape drift, no schema↔docs breaking mismatch, no oneOf regression, no released-artifact mutation.

Medium findings

  • static/compliance/source/specialisms/content-standards/index.yaml:600 — get_creative_features doc_ref points to a non-existent route
  • static/compliance/source/protocols/brand/index.yaml:175 — search_brands doc_ref dangles; task is undocumented

Two medium doc_ref findings, neither in data-loss/schema/infra category, no blocking findings, no gated paths satisfied issue (gated_paths: false), high_risk false, no team gate. Two mediums fall through the decision table to row 9 → approve. Worth a follow-up to wire up the dangling doc_ref links, but not blocking.

Medium findings

  • static/compliance/source/specialisms/content-standards/index.yaml:600 — get_creative_features doc_ref points to a non-existent route
  • static/compliance/source/protocols/brand/index.yaml:175 — search_brands doc_ref dangles; task is undocumented

aao-secretariat[bot]
aao-secretariat Bot previously approved these changes Aug 8, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval: no reviewable delta since the prior approval; re-submitting after stale-review dismissal.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval: no reviewable delta since the prior approval; re-submitting after stale-review dismissal.

@bokelley
bokelley requested a review from a team August 8, 2026 05:06
@bokelley
bokelley merged commit 1656819 into main Aug 8, 2026
31 checks passed
@bokelley
bokelley deleted the feat/three-missing-task-storyboards branch August 8, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant