feat(compliance): cover three missing tasks - #6172
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — additive compliance coverage restoring three experimental-task storyboard steps (search_brands, get_creative_features, get_media_buy_artifacts).
Checked: sample requests conform to request-schema required fields; validation paths (brands, results, artifacts, media_buy_id) match the response schemas; controller_seeding placement (under prerequisites) and top-level fixtures.media_buys match the established media-buy scenario pattern; changeset is minor, appropriate for additive coverage. No wire-shape drift, no schema↔docs breaking mismatch, no oneOf regression, no released-artifact mutation.
Medium findings
- static/compliance/source/specialisms/content-standards/index.yaml:600 — get_creative_features doc_ref points to a non-existent route
- static/compliance/source/protocols/brand/index.yaml:175 — search_brands doc_ref dangles; task is undocumented
Two medium doc_ref findings, neither in data-loss/schema/infra category, no blocking findings, no gated paths satisfied issue (gated_paths: false), high_risk false, no team gate. Two mediums fall through the decision table to row 9 → approve. Worth a follow-up to wire up the dangling doc_ref links, but not blocking.
Medium findings
- static/compliance/source/specialisms/content-standards/index.yaml:600 — get_creative_features doc_ref points to a non-existent route
- static/compliance/source/protocols/brand/index.yaml:175 — search_brands doc_ref dangles; task is undocumented
Summary
Restores the bounded, reviewable slice from closed PR #4294 on a clean branch based on
main:search_brandson the existing brand protocol storyboardget_creative_featureson the existing content-standards storyboardget_media_buy_artifactson the existing content-standards storyboard, with controller-seeded buy stateEach task is gated with step-level
requires_tool, so agents that do not advertise an experimental task receivemissing_toolrather than failing the whole storyboard. None were added to storyboard-levelrequired_tools.The review follow-up also fixes both dangling
doc_refvalues:get_creative_featuresnow points to its governance task page, andsearch_brandsnow has a task reference included in live navigation.Verification
git diff --checkpassesPart of #4291. Remaining umbrella tracks are split into focused follow-ups.