Skip to content

feat(reporting): extend reporting-frequency for measured channels; surface print guide in nav - #6240

Merged
bokelley merged 1 commit into
mainfrom
ooh-cadence-housekeeping
Aug 6, 2026
Merged

feat(reporting): extend reporting-frequency for measured channels; surface print guide in nav#6240
bokelley merged 1 commit into
mainfrom
ooh-cadence-housekeeping

Conversation

@bokelley

@bokelley bokelley commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Two small, additive changes that measured/physical channels (OOH, radio, print) sit on, converged in review on #6138 and #6140:

  • reporting-frequency gains weekly, quarterly, post_campaign. These are the publication cadences of audience-currency channels: weekly OOH/radio increments (Geopath, RAJAR), quarterly measurement-cycle updates (Geopath DEC), and flights only reconcilable in arrears. The enum description and optimization-reporting docs now state the eligibility principle from the [Scoping] Radio & static OOH: bring channel measurement + delivery to linear-TV parity #6138 thread: a product's declared cadence gates mid-flight optimization — nothing should optimize against data that arrives quarterly.
  • docs/creative/channels/print is added to navigation (plus the matching snapshot redirect). The page has shipped since the collection/installment work (feat: collection/installment model, deadlines, and print channel support #1642) but has never been reachable from docs.json nav.

Doc value lists (update_media_buy, get_media_buy_delivery, optimization-reporting) updated to match the enum. Changeset included (minor).

Notes

Refs #6138, #6140

🤖 Generated with Claude Code

…rface print guide in nav

Adds weekly, quarterly, and post_campaign to reporting-frequency —
the publication cadences of audience-currency channels (weekly OOH/
radio increments, quarterly circulation cycles, post-flight-only
reconciliation) — with guidance that declared cadence gates
optimization eligibility. Converged on #6138/#6140.

Also lists the print channel guide in docs.json navigation; the page
has shipped since the collection/installment work but was unreachable.

Refs #6138, #6140

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@aao-secretariat aao-secretariat Bot added the ladon/needs-human-review Ladon has escalated this PR for human review. label Aug 6, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated path requires human/CODEOWNERS review.

This PR extends the shared reporting-frequency enum with weekly, quarterly, and post_campaign, updates the three normative docs listings coherently, and ships a correct minor changeset. The reviewer found the schema↔docs coherence intact (all three consuming schemas $ref the shared enum), no released dist/** artifacts touched, and no blocking findings.

However, static/schemas/source/enums/reporting-frequency.json matches the deterministic gated-path glob static/schemas/source/** (gated_paths: true), and review_decision is REVIEW_REQUIRED — not APPROVED. Per decision-table row 2, this PR cannot be auto-approved and must go to human/CODEOWNERS review.

Escalation reasons

  • static/schemas/source/enums/reporting-frequency.json is under the hard approval gate (static/schemas/source/**) and review_decision is REVIEW_REQUIRED; a real human/CODEOWNERS approval is required before merge.

No blocking findings exist; the diff is clean and additive. Once a CODEOWNERS approval lands, this can fall through to approve.

Why human review

  • static/schemas/source/enums/reporting-frequency.json is under the hard approval gate (static/schemas/source/**) and review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required before merge
  • This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/enums/reporting-frequency.json (modified) matches static/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ladon/needs-human-review Ladon has escalated this PR for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant