Repository navigation
fix(ecs): update() accepts undefined to remove a required component - #223
Merged
Merged
Conversation
…nder exactOptionalPropertyTypes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update(entity, { component: undefined })removes a component at runtime. But underexactOptionalPropertyTypes,EntityUpdateValues<C> = Partial<Omit<C, "id">>only makes each key optional and rejects an explicitundefined. Removing a required component therefore needed a cast at the call site.EntityUpdateValues<C>now explicitly acceptsundefinedfor each value:{ [K in keyof Omit<C, "id">]?: C[K] | undefined }. The core store, public store, transactional store and transaction ops all use this type, so all of them are fixed.exactOptionalPropertyTypesthe type is identical to before. No runtime change.packages/data/type-tests/exact-optionalproject compiled withexactOptionalPropertyTypes, referenced frompackages/data/tsconfig.jsonsotsc -bruns it. It checks only against the built.d.ts, so the rest of the package isn't held to the stricter flag. The test failed (TS2379) on the old type and passes on the new one, and a wrong value type is still rejected.Test plan
pnpm -r run typecheck(tsbuildinfo cleared)pnpm run lintpackages/datatests: 301 files / 3637 tests pass🤖 Generated with Claude Code