Repository navigation
[FFP-122782] Collision-free undo of added columns; redo insert records stored values - #224
Merged
Merged
Conversation
…tored values Undo of an added column records undefined instead of the "_$_DELETE_$_" string sentinel, so a user value equal to it is no longer dropped. Redo inserts and changed entities carry the values that landed (defaults, factories) so replay restores e.g. the original guid. Refs FFP-122782. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses FFP-122782.
undefined(removes the column on replay) instead of the"_$_DELETE_$_"string, so a user value equal to that string is never dropped by undo/redo or rebase. TheDELETEexport is removed; no sentinel to copy.insertredo ops andchangedEntitiesnow carry the stored row (defaults and default-factory output), so replaying a redo insert restores the original guid.Tests: sentinel-valued user data round-trips through undo/redo; factory-minted guid survives undo→redo. Full suite and typecheck pass.
🤖 Generated with Claude Code