Skip to content

Add setRaw() method for Set type encoder (#1086) #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vyazelenko merged 2 commits into from
Sep 9, 2026
Merged

Add setRaw() method for Set type encoder (#1086) #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eab64e
Add setRaw() method for Set type encoder (#1086)"
aymenjam Sep 7, 2026
72a5e12
Simplify shouldGenerateBitSetRawAccessor test per review feedback
aymenjam Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,11 +1902,11 @@ private void generateBitSet(final List<Token> tokens) throws IOException
final String encoderName = encoderName(bitSetName);
final List<Token> choiceList = tokens.subList(1, tokens.size() - 1);
final String implementsString = implementsInterface(Flyweight.class.getSimpleName());
final Encoding encoding = token.encoding();

registerTypesPackageName(token, ir);
try (Writer out = outputManager.createOutput(decoderName))
{
final Encoding encoding = token.encoding();
generateFixedFlyweightHeader(
out, token, decoderName, implementsString, readOnlyBuffer, fqReadOnlyBuffer, PACKAGES_EMPTY_SET);
out.append(generateChoiceIsEmpty(encoding.primitiveType()));
Expand All @@ -1931,6 +1931,18 @@ private void generateBitSet(final List<Token> tokens) throws IOException
generateFixedFlyweightHeader(
out, token, encoderName, implementsString, mutableBuffer, fqMutableBuffer, PACKAGES_EMPTY_SET);
generateChoiceClear(out, encoderName, token);

new Formatter(out).format(
"\n" +
" public %s setRaw(final %s value)\n" +
" {\n" +
" %s;\n" +
" return this;\n" +
" }\n",
encoderName,
primitiveTypeName(token),
generatePut(encoding.primitiveType(), "offset", "value", byteOrderString(encoding)));

generateChoiceEncoders(out, encoderName, choiceList);
out.append("}\n");
}
Expand Down
24 changes: 24 additions & 0 deletions sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/JavaGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,30 @@ void shouldGenerateBitSetCodecs() throws Exception
assertTrue(getCruiseControl(extrasDecoder));
}

@Test
void shouldGenerateBitSetRawAccessor() throws Exception
{
final UnsafeBuffer buffer = new UnsafeBuffer(new byte[4096]);

generator().generate();

final Object encoder = wrap(buffer, compileCarEncoder().getConstructor().newInstance());
final Object decoder = getCarDecoder(buffer, encoder);

final Object extrasEncoder = getExtras(encoder);
final Object extrasDecoder = getExtras(decoder);

final Method getRawMethod = extrasDecoder.getClass().getMethod("getRaw");
final Class<?> rawType = getRawMethod.getReturnType();
final Method setRawMethod = extrasEncoder.getClass().getMethod("setRaw", rawType);

final Short boxedValue = (short)0b0000_0101;
setRawMethod.invoke(extrasEncoder, boxedValue);

final Object result = getRawMethod.invoke(extrasDecoder);
assertEquals(boxedValue, result);
}

@Test
void shouldGenerateEnumCodecs() throws Exception
{
Expand Down
Loading