Repository navigation
README: trim the Quickstart, build the worker image with make images - #120
Merged
Merged
Conversation
`make images` now also builds and pushes Substrate's ateworker-gvisor worker image to $(ATE_ENV_IMAGE_REPO). It builds the Substrate version pinned in go.mod, from that module's own directory so its .ko.yaml and go.sum apply and this repo's go.mod and go.sum stay unchanged. Image naming (--base-import-paths) and the version stamp match Substrate's `ate-setup publish worker-images`. The stamp goes through GOFLAGS because older ko releases do not have --ldflags. The target prints the ref to pass as --worker-image next to --api-image and --guest-image. README: - Add a "Build and Push the Images" step (`make images`) and use $ATE_ENV_IMAGE_REPO in the --worker-image example. - Cut the prerequisites down to the minimum Substrate version, the version ate-env is built against, and a GCS snapshots bucket. Remove the commit-by-commit compatibility notes and the paragraph on re-registering templates after an upgrade. - Remove the separate Images section, the --wake-budget paragraph, the "from a source build" comments, and all --rootfs-image material (also in docs/release.md). - Use <gcs-bucket> for --snapshots-bucket. - List only the MCP tools internal/mcp defines (read_file, write_file, shell), and drop the edit_file, glob and grep entries for tools that do not exist. Signed-off-by: Jaana Dogan <jbd@google.com>
Jaana Dogan (rakyll)
requested review from
Lior Lieberman (LiorLieberman) and
Tomer Glottmann (tomergee)
October 27, 2026 05:16
Lior Lieberman (LiorLieberman)
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make images) and use $ATE_ENV_IMAGE_REPO in the --worker-image example.