Repository navigation
Conversation
…ucket atelet's object-store plugin reads micro-VM sandbox assets under kata-assets/ with its own identity, and snapshot transfers on GCS run on per-actor tokens. setup-gcp now grants atelet object viewer on that prefix through an IAM condition, instead of object admin on the whole bucket. The bucket policy is read and written at version 3, which conditions need.
Merged
2 tasks done
The project-wide grant covered the snapshot bucket too, so atelet could still read and write every snapshot. atelet keeps only Artifact Registry reader at project level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for discussion. This is one of two alternatives for removing atelet's access to the snapshot bucket, the other is #3037. Not tested on a cluster yet.
Nodes read micro-VM sandbox assets with their own identity, and the assets live in the snapshot bucket, so atelet still holds object admin on it. Here the assets stay where they are, and atelet gets object viewer limited to kata-assets/ by an IAM condition instead. setup-gcp also stops granting atelet object admin on the whole project, which covered the snapshot bucket too.
Existing installs keep the old grants, since setup-gcp only adds bindings. Remove them by hand:
Related to #777
AI use: AI-assisted, I reviewed it.