Repository navigation
ate-api-server's --egress-gateway-spiffe-id is repeatable, and ate-setup sets it from ATE_EGRESS_GATEWAY_EXTRA_SPIFFE_IDS #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tim Hockin (thockin)
merged 6 commits into
agent-substrate:main
from
thompsonmax:credential-minter-role
Oct 29, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7cbb12a
authz: let a credential plugin mint actor JWTs
thompsonmax 48c5905
ateapi: accept a list of credential minter SPIFFE IDs
thompsonmax c8d5a6d
ateapi: accept more than one egress gateway SPIFFE ID
thompsonmax 8594ebb
ateapi: take one egress gateway SPIFFE ID per flag
thompsonmax 49ccb62
ate-setup: share the ate-api-server flag rewrite
thompsonmax b9afc9c
ate-setup: add egress gateway extra SPIFFE IDs setting
thompsonmax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,7 +233,7 @@ func EnsureStoreAndModel(ctx context.Context, pool *pgxpool.Pool, fgaServer *ser | |
| // every check, independent of any stored AccessPolicy. | ||
| type SystemPrincipals struct { | ||
| ControllerSPIFFEID string | ||
| EgressGatewaySPIFFEID string | ||
| EgressGatewaySPIFFEIDs []string | ||
| IngressRouterSPIFFEID string | ||
| AteletSPIFFEID string | ||
| APIServerSidecarSPIFFEID string | ||
|
|
@@ -289,16 +289,22 @@ func parseBootstrapOwners(ids []string) (map[string]struct{}, error) { | |
| // parseSystemPrincipals validates system's SPIFFE IDs and maps each OpenFGA | ||
| // user string to the system component roles it holds. | ||
| func parseSystemPrincipals(system SystemPrincipals) (map[string][]string, error) { | ||
| bindings := []struct { | ||
| if len(system.EgressGatewaySPIFFEIDs) == 0 { | ||
| return nil, fmt.Errorf("no %s SPIFFE ID", RoleEgressGateway) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we be doing flag validation WAY earlier than this? |
||
| } | ||
| type binding struct { | ||
| role string | ||
| spiffeID string | ||
| }{ | ||
| } | ||
| bindings := []binding{ | ||
| {role: RoleController, spiffeID: system.ControllerSPIFFEID}, | ||
| {role: RoleEgressGateway, spiffeID: system.EgressGatewaySPIFFEID}, | ||
| {role: RoleIngressRouter, spiffeID: system.IngressRouterSPIFFEID}, | ||
| {role: RoleAtelet, spiffeID: system.AteletSPIFFEID}, | ||
| {role: RoleAPIServerSidecar, spiffeID: system.APIServerSidecarSPIFFEID}, | ||
| } | ||
| for _, id := range system.EgressGatewaySPIFFEIDs { | ||
| bindings = append(bindings, binding{role: RoleEgressGateway, spiffeID: id}) | ||
| } | ||
| out := make(map[string][]string, len(bindings)) | ||
| for _, b := range bindings { | ||
| if _, err := spiffeid.FromString(b.spiffeID); err != nil { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The words here are confusing to me. "next to atenet-egress" - what does that mean? "In addition to" ?