Repository navigation
manifests: remove the GKE-specific install content - #3399
Draft
Steven Shriver (stshrive) wants to merge 2 commits into
Draft
Steven Shriver (stshrive) wants to merge 2 commits into
Steven Shriver (stshrive) wants to merge 2 commits into
Conversation
The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Signed-off-by: Steven Shriver <6007067+stshrive@users.noreply.github.com>
Core installs now render only provider-neutral manifests. The GKE pieces move to https://github.com/ai-on-gke/substrate-gke (ai-on-gke/substrate-gke#82), which adds them to manifests/ate-install/base before running ate-setup. Removed from core: - atenet-router-monitoring.yaml, the GMP PodMonitoring, and its base entry. The router manifest test now checks the envoy-metrics port the provider's scrape targets instead of the PodMonitoring itself. - The cloud.google.com/compute-class toleration on atelet. - The GKE managed OTel collector endpoint. ate-otel-config.yaml sets no endpoint, and the agentgateway component declares AGENTGATEWAY_OTLP_ADDRESS empty for the provider to set; the kind overlays still set their in-cluster collector. - cloudsql/proxy-sidecar-patch.yaml and the ate-setup code that applied it, along with the rest of ate-setup's Cloud SQL support: the --ateapi-postgres-cloudsql-{instance,gsa,iam-auth,ip-type} settings, DSN synthesis, adoption of a recorded Cloud SQL install, and the Workload Identity annotation. A non-empty ATE_API_POSTGRES_CLOUDSQL_* variable now fails with an error that points to substrate-gke. An external database is set through ATE_API_POSTGRES_READ_WRITE_CONNECTION_STRING. Single-component redeploys now take ate-otel-config from the same render as the full install, applying only that ConfigMap, so they keep an endpoint set by the kind overlay or by a provider's component. Signed-off-by: Steven Shriver <6007067+stshrive@users.noreply.github.com>
Steven Shriver (stshrive)
force-pushed
the
dev/remove-gcp-manifests
branch
from
October 28, 2026 21:55
dddf8ec to
e891b41
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core installs now render only provider-neutral manifests. The GKE pieces
move to https://github.com/ai-on-gke/substrate-gke (ai-on-gke/substrate-gke#82),
which adds them to manifests/ate-install/base before running ate-setup.
Removed from core:
entry. The router manifest test now checks the envoy-metrics port the
provider's scrape targets instead of the PodMonitoring itself.
endpoint, and the agentgateway component declares
AGENTGATEWAY_OTLP_ADDRESS empty for the provider to set; the kind
overlays still set their in-cluster collector.
along with the rest of ate-setup's Cloud SQL support: the
--ateapi-postgres-cloudsql-{instance,gsa,iam-auth,ip-type} settings, DSN
synthesis, adoption of a recorded Cloud SQL install, and the Workload
Identity annotation. A non-empty ATE_API_POSTGRES_CLOUDSQL_* variable now
fails with an error that points to substrate-gke. An external database is
set through ATE_API_POSTGRES_READ_WRITE_CONNECTION_STRING.
Single-component redeploys now take ate-otel-config from the same render
as the full install, applying only that ConfigMap, so they keep an
endpoint set by the kind overlay or by a provider's component.
Part of #2304
CURRENTLY DRAFT, WAITING ON #3396
Signed-off-by: stshrive stshrive@google.com