Repository navigation
docs: fix outdated statements in the egress guides - #3442
Merged
Lior Lieberman (LiorLieberman) merged 4 commits intoOct 31, 2026
Merged
Lior Lieberman (LiorLieberman) merged 4 commits into
Lior Lieberman (LiorLieberman) merged 4 commits into
Conversation
Yufan Su (yufan-su)
requested review from
Lior Lieberman (LiorLieberman) and
Bowei Du (bowei)
October 29, 2026 17:21
Comment on lines
+205
to
+208
| The setting can also come from `ATE_CREDENTIAL_PROVIDER` or from | ||
| `atenet.egress.credentialProvider` in the `--config` file (see | ||
| [Precedence](operator-install.md#precedence)). Its value is a JSON object with | ||
| these keys; any other key is an error: |
Collaborator
There was a problem hiding this comment.
Max Thompson (@thompsonmax) can you check for correctness after your recent change?
Collaborator
Author
There was a problem hiding this comment.
I see Max already have the doc change in #3410 so just reverted here
Collaborator
There was a problem hiding this comment.
Ah, forgot to move that out of draft earlier. Just sent it for review. Remaining changes here LGTM.
Max Thompson (thompsonmax)
self-requested a review
October 30, 2026 19:22
Signed-off-by: Yufan Su <yufans@google.com>
Signed-off-by: Yufan Su <yufans@google.com>
Signed-off-by: Yufan Su <yufans@google.com>
Yufan Su (yufan-su)
force-pushed
the
egress-doc-fix
branch
2 times, most recently
from
October 30, 2026 22:59
eaacd49 to
251081c
Compare
Max Thompson (thompsonmax)
approved these changes
Oct 30, 2026
Yufan Su (yufan-su)
force-pushed
the
egress-doc-fix
branch
from
October 30, 2026 23:11
251081c to
2760cb8
Compare
Lior Lieberman (LiorLieberman)
previously approved these changes
Oct 30, 2026
Yufan Su (yufan-su)
force-pushed
the
egress-doc-fix
branch
from
October 30, 2026 23:20
2760cb8 to
2c9a31d
Compare
Lior Lieberman (LiorLieberman)
approved these changes
Oct 30, 2026
Lior Lieberman (LiorLieberman)
enabled auto-merge
October 30, 2026 23:21
Lior Lieberman (LiorLieberman)
pushed a commit
that referenced
this pull request
Oct 31, 2026
… egress guides (#3516)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
egress-credential-injection.mdhttprules.ATE_CREDENTIAL_PROVIDERor fromatenet.egress.credentialProviderin the--configfile.ext-proclog command works on the Envoy dataplane only.replaceHeadersthroughout, to match the examples.egress-trust-bundle.mdkubectl ate create actor-template -frejects, and its trailing-slashmountPathfails validation. It is now a protojson excerpt.unusable contentserror does not exist. The doc now shows the error atelet returns when the egress ClusterTrustBundle is missing.distroless/base-debian13image.egress-traffic.mdtls_passthrough. It relays whatever runs inside the TLS without inspecting it.400 Bad Request. A client that waits for the server is closed after about 1 second. atunnel does not log either case.AI use: I used Claude Code to audit the egress docs against the code, run a test for all the outdated statement. I reviewed every change.