feat(transports): add HTTP/WebSocket transport support#162
Open
alexhancock wants to merge 1 commit into
Open
Conversation
Adds server-side HTTP/WebSocket transport support for exposing ACP agents over HTTP/WS, along with a client transport implementing ConnectTo<Client> for connecting to remote agents over HTTP/SSE.
Contributor
Author
|
cc @nikomatsakis @benbrandt as I don't see how to add as reviewers after creation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/WebSocket transport support
Adds server-side HTTP/WebSocket transport support for exposing ACP agents over HTTP/WS, along with a client transport implementing ConnectTo for connecting to remote agents over HTTP/SSE.
Makes it possible to bring an agent server or client and connect it to the new remote transport
Questions
I did some smoke tests in a personal repo here to exercise both client <-> server over HTTP+SSE and WS https://github.com/alexhancock/pocs/tree/main/acp-http-smoke-test but wonder what we want for the SDK?