fix(core): guard null input in ToolValidator.validateInput to prevent NPE#2337
Open
1143506050 wants to merge 1 commit into
Open
fix(core): guard null input in ToolValidator.validateInput to prevent NPE#23371143506050 wants to merge 1 commit into
1143506050 wants to merge 1 commit into
Conversation
When a ToolUseBlock has parsed arguments in its `input` map but no raw
`content` string, `ToolExecutor.executeCore` passes `null` to
`ToolValidator.validateInput()`, which forwards it to networknt-schema's
`validate(null, …)`. networknt-schema then throws
NullPointerException: argument "content" is null
Treat null/blank input as `"{}"` before validation so that optional-field
schemas pass cleanly and required-field schemas still surface the expected
validation errors.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
wyp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
CLA Not Signed The Contributor License Agreement (CLA) check is currently pending on this PR ( @1143506050 please sign the CLA via the CLA assistant badge in the comment above, or visit https://cla-assistant.io/agentscope-ai/agentscope-java. Once signed, the Automated check by github-manager-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ToolUseBlock has parsed arguments in its
inputmap but no rawcontentstring,ToolExecutor.executeCorepassesnulltoToolValidator.validateInput(), which forwards it to networknt-schema'svalidate(null, …). networknt-schema then throws:This causes tool calls to fail with a misleading error:
Parameter validation failed: Schema validation error: argument "content" is null
Treat null/blank input as
"{}"before validation so that optional-fieldschemas pass cleanly and required-field schemas still surface the expected
validation errors.