feat: allow adding extra attributes to generated toolchains#657
Merged
Conversation
aherrmann
approved these changes
May 20, 2026
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Thank you, that looks great!
Thanks for adding the test coverage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support for per
zig.toolchain(...)extra exec constraints, target constraints,and target settings as well root-level additive equivalent tag_class to the zig extension.
This allows users to customize the generated toolchains and will allow the broader story of allowing local only zig actions.
Added tests follow the same logic as the ones before.