Skip to content

Fix terminal Q-value in QLearningAgent/SARSA (use r, not r1) (#1247) #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmeoli merged 1 commit into from
Jun 27, 2026
+2 −2
Merged

Fix terminal Q-value in QLearningAgent/SARSA (use r, not r1) (#1247) #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reinforcement_learning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def __call__(self, percept):
actions_in_state = self.actions_in_state

if s in terminals:
Q[s, None] = r1
Q[s, None] = r
if s is not None:
Nsa[s, a] += 1
Q[s, a] += alpha(Nsa[s, a]) * (r + gamma * max(Q[s1, a1]
Expand Down Expand Up @@ -330,7 +330,7 @@ def __call__(self, percept):
a1 = max(actions_in_state(s1), key=lambda a2: self.f(Q[s1, a2], Nsa[s1, a2]))

if s in terminals:
Q[s, None] = r1
Q[s, None] = r
if s is not None:
Nsa[s, a] += 1
# on-policy update: bootstrap on the actually-chosen next action a1
Expand Down
Loading