docs(machine-config): kubelet & firewall guides + disruption/chrony fixes (backport to release-1.0)#112
Open
chinameok wants to merge 2 commits into
Open
docs(machine-config): kubelet & firewall guides + disruption/chrony fixes (backport to release-1.0)#112chinameok wants to merge 2 commits into
chinameok wants to merge 2 commits into
Conversation
…clarify disruption-policy and chrony restart requirements - Add 'Configuring Kubelet': manage kubelet settings via a --config-dir drop-in with MachineConfig; settings you can change (with recommended ranges), platform-managed settings, and when changes take effect. - Add 'Managing Firewall Ports': open additional ports via a firewalld policy file. - node_disruption: explicit warning that file changes default to None and need a disruption policy to take effect. - managing (chrony): add the node disruption policy required to restart chronyd.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying alauda-immutable-infra with
|
| Latest commit: |
e656d08
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c466d1d.alauda-immutable-infra.pages.dev |
| Branch Preview URL: | https://docs-machine-config-day2-rel.alauda-immutable-infra.pages.dev |
…e kubelet config directory Document the by-design behavior that declaring a unit (e.g. kubelet.service) under systemd.units transfers ownership of the whole unit to Machine Configuration—so removing the MachineConfig removes the base unit and leaves the node NotReady. Clarify why the --config-dir drop-in is written as a storage.files file instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111 to
release-1.0.Adds the Configuring Kubelet and Managing Firewall Ports guides, the node-disruption files-default warning, and the chrony restart policy. Cherry-picked cleanly from master. See #111 for details.