fix: forbid profile commands when config is env set#48
Merged
leonkenneth merged 3 commits intoJul 13, 2026
Conversation
Contributor
## Summary - update the lakehouse integration assertion to expect `_from_env` when `ALTERTABLE_API_KEY` is supplied - keep the test aligned with PR #48's env-config isolation behavior ## Verification - `./cli/node_modules/.bin/tsc -p tsconfig.tests.json` - `bun test "$PWD"/tests/scripting.test.ts` - `bun test "$PWD"/tests/profile.test.ts` I could not run `bun test "$PWD"/tests/integration.e2e.ts` locally because this environment does not have Docker available to start the mock lakehouse service used by CI.
albert20260301
approved these changes
Jul 10, 2026
francoischalifour
approved these changes
Jul 13, 2026
Comment on lines
+552
to
+560
| const ENV_CONFIG_VARS: ReadonlyArray<{ name: string; secret: boolean }> = [ | ||
| { name: "ALTERTABLE_API_KEY", secret: true }, | ||
| { name: "ALTERTABLE_BASIC_AUTH_TOKEN", secret: true }, | ||
| { name: "ALTERTABLE_LAKEHOUSE_USERNAME", secret: false }, | ||
| { name: "ALTERTABLE_LAKEHOUSE_PASSWORD", secret: true }, | ||
| { name: "ALTERTABLE_ENV", secret: false }, | ||
| { name: "ALTERTABLE_API_BASE", secret: false }, | ||
| { name: "ALTERTABLE_MANAGEMENT_API_BASE", secret: false }, | ||
| ]; |
Member
There was a problem hiding this comment.
I'll send a follow up refactor to better manage our env variables.
leonkenneth
deleted the
fix-forbid-profile-commands-when-config-is-env-set
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is also a change in behavior but I think clearer: ENV-var configuration is all-or-nothing and doesn't inherit any profile values
happy to discuss