Repository navigation
Fix bug where transient IMDS failure could revert secondary ip addres… - #162
Merged
Merged
Conversation
…ses. Modify subnet calls in create_if_overrides function and add http failure logging.
joeysk2012
force-pushed
the
fix-local-ipv4
branch
from
July 14, 2026 17:14
9d7f40a to
658164e
Compare
Contributor
Author
|
Reviewed offline, merging. |
mjnowen
added a commit
to mjnowen/amazon-ec2-net-utils
that referenced
this pull request
Sep 30, 2026
Since v2.7.5 (amazonlinux#162), get_meta() forwards curl's stderr to syslog at err priority on every attempt. Single-attempt callers query keys that may legitimately be absent (ipv4-prefix when no prefix is delegated, network-card on single-card instance types), so each refresh of a secondary interface now logs 'curl: (22) The requested URL returned error: 404' as an error. get_meta() already suppresses its own summary error for max_tries=1 for exactly this reason. Apply the same rule to curl's stderr, and keep forwarding it at err priority for retrying callers. Add regression tests in tests/imds.bats covering both paths. Fixes amazonlinux#175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if transient IMDS call fails during mid execution of
refresh-policy-routesthen, a the secondary ip configec2_alias.confwill be removed. This happens because there get_imds fails and the shell$(..)will swallow the error and addresses will be returned as a empty string. This could also happen for subnets increate_if_overridesand we do a best effort to fix this as well.Issue #, if available: #161
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.