Repository navigation
Conversation
Author
|
Applicable feedback carried over from Kanti's reviews of other repositories:
|
added 6 commits
October 23, 2026 16:28
Preserve supported PHP and TYPO3 versions, check dependency bounds, and add regression tests for compatibility fixes.
Kanti
reviewed
Oct 27, 2026
| include: | ||
| - php: '8.2' | ||
| typo3: '13' | ||
| dependencies: latest |
Member
There was a problem hiding this comment.
dependencies: latest
This isn't necessary; we didn't have it before, and we don't need it now either.
Kanti
reviewed
Oct 27, 2026
| @@ -0,0 +1,46 @@ | |||
| #!/bin/sh | |||
Member
There was a problem hiding this comment.
we do not want a shell script for this, we do not need this here.
We did not have this before.
Kanti
reviewed
Oct 27, 2026
| parallel: | ||
| enabled: false | ||
| parameters: | ||
| convention.fractor_enable: false |
Kanti
reviewed
Oct 27, 2026
| - { resource: vendor/pluswerk/grumphp-config/grumphp.yml } | ||
| grumphp: | ||
| parallel: | ||
| enabled: false |
Kanti
reviewed
Oct 27, 2026
| use Rector\Caching\ValueObject\Storage\FileCacheStorage; | ||
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| $rectorConfig->phpVersion(80200); |
Member
There was a problem hiding this comment.
We do not want a fixed version. We have the automated php version configuration.
Kanti
reviewed
Oct 27, 2026
| }, | ||
| "require-dev": { | ||
| "pluswerk/grumphp-config": "^7.2.0 || ^10.1.4", | ||
| "pluswerk/grumphp-config": "^7.2.0 || ^10.1.4 || ^11.2.0", |
Member
There was a problem hiding this comment.
can we remove version 7 or even version 10?
Kanti
reviewed
Oct 27, 2026
Comment on lines
-19
to
+41
| - uses: actions/checkout@v2 | ||
| - uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.composer/cache/files | ||
| key: ${{ runner.os }}-${{ matrix.php }}-composer-${{ hashFiles('**/composer.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-${{ matrix.php }}-composer- | ||
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --dev --ignore-platform-req=php+ | ||
| - run: composer install --no-interaction --no-progress --ignore-platform-req=php+ | ||
| - run: ./vendor/bin/grumphp run --ansi | ||
| extensions: apcu, bcmath, gd, intl, mbstring, pdo_sqlite, sqlite3, zip | ||
| coverage: pcov | ||
| tools: composer:v2 | ||
| ini-values: apc.enable_cli=1, memory_limit=1G | ||
| - name: Resolve and check compatibility | ||
| run: sh Build/Scripts/check-compatibility.sh ${{ matrix.php }} ${{ matrix.typo3 }} ${{ matrix.dependencies }} |
Member
There was a problem hiding this comment.
we should not change that much in a simple php upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow and test PHP 8.5 with TYPO3 13.4. Align Composer requirements and the CI matrix, removing TYPO3 12. No application code changes.
Breaking change: TYPO3 12 is no longer supported on this development branch.
Validation: the GitHub Actions branch workflow passed for
5e0816402064e30f3c33915de3f829927af0dd68. This PR targetsmain.