Skip to content

Delay adding SharedBounds / SharedElement #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riggaroo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Delay adding SharedBounds / SharedElement #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab04b13
Update sharedBounds / sharedElement to check if the item is visible i…
riggaroo Aug 19, 2026
8a3191c
Add Benchmark for navigation between list -> detail
riggaroo Aug 20, 2026
9740a62
Improvements to static shared element composition locals
riggaroo Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Jetsnack/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ dependencies {
implementation(libs.androidx.navigation.compose)

implementation(libs.androidx.compose.runtime)
implementation(libs.androidx.compose.runtime.tracing)
implementation("androidx.tracing:tracing-perfetto:1.0.1")
implementation("androidx.tracing:tracing-perfetto-binary:1.0.1")
implementation("androidx.tracing:tracing-perfetto-handshake:1.0.1")
implementation(libs.androidx.compose.foundation)
implementation(libs.androidx.compose.foundation.layout)
implementation(libs.androidx.compose.ui)
Expand Down
5 changes: 4 additions & 1 deletion Jetsnack/app/proguard-benchmark-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,7 @@

# When generating the baseline profile we want the proper names of
# the methods and classes
-dontobfuscate
-dontobfuscate

-keep class androidx.tracing.perfetto.** { *; }
-keep class androidx.compose.runtime.tracing.** { *; }
6 changes: 3 additions & 3 deletions Jetsnack/app/src/main/java/com/example/jetsnack/ui/JetsnackApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ import androidx.compose.foundation.layout.systemBarsPadding
import androidx.compose.material3.SnackbarHost
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.compositionLocalOf
import androidx.compose.runtime.getValue
import androidx.compose.runtime.staticCompositionLocalOf
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import androidx.navigation.NavBackStackEntry
Expand Down Expand Up @@ -166,5 +166,5 @@ fun MainContainer(modifier: Modifier = Modifier, onSnackSelected: (Long, String,
}
}

val LocalNavAnimatedVisibilityScope = compositionLocalOf<AnimatedVisibilityScope?> { null }
val LocalSharedTransitionScope = compositionLocalOf<SharedTransitionScope?> { null }
val LocalNavAnimatedVisibilityScope = staticCompositionLocalOf<AnimatedVisibilityScope?> { null }
val LocalSharedTransitionScope = staticCompositionLocalOf<SharedTransitionScope?> { null }
Loading
Loading