fix(bazel): verify TypeScript version from MODULE.bazel instead of lockfile#3856
Merged
Conversation
See associated pull request for more information. Closes angular#3845 as a pr takeover
angular-robot
Bot
added
the
area: build & ci
alan-agius4
force-pushed
the
pr-takeover-3845
branch
from
July 20, 2026 10:23
b9ce0af to
541825f
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alan-agius4
force-pushed
the
pr-takeover-3845
branch
from
July 20, 2026 10:25
541825f to
9e1df0b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alan-agius4
force-pushed
the
pr-takeover-3845
branch
from
July 20, 2026 10:28
9e1df0b to
841ef35
Compare
Contributor
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript version validation logic to check the version directly from MODULE.bazel instead of parsing MODULE.bazel.lock. It also updates several Bazel dependencies across the workspace. A review comment suggests improving the regular expression used to extract the TypeScript version from MODULE.bazel by adding a word boundary after ts_version to prevent false positive matches.
…ckfile In recent versions of `aspect_rules_ts`, the module extension is implemented in a way that doesn't record the version metadata in `MODULE.bazel.lock` under the expected path or format, causing `validate_ts_version_match` to fail to extract the version, resolving it to `unknown` and resulting in validation failures. To resolve this issue, the `verify-typescript.mjs` validation script is refactored to read and extract `ts_version` directly from `MODULE.bazel` instead. The macro definition in `defs.bzl` and the invocation in `BUILD.bazel` are updated to pass `MODULE.bazel` instead of `MODULE.bazel.lock`.
alan-agius4
force-pushed
the
pr-takeover-3845
branch
from
July 20, 2026 10:31
841ef35 to
590828b
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In recent versions of
aspect_rules_ts, the module extension is implemented in a way that doesn't record the version metadata inMODULE.bazel.lockunder the expected path or format, causingvalidate_ts_version_matchto fail to extract the version, resolving it tounknownand resulting in validation failures.To resolve this issue, the
verify-typescript.mjsvalidation script is refactored to read and extractts_versiondirectly fromMODULE.bazelinstead. The macro definition indefs.bzland the invocation inBUILD.bazelare updated to passMODULE.bazelinstead ofMODULE.bazel.lock.